Work around MSBuild task ordering bug

[jjonescz]

Fixes #74156.

[rainersigwald]

This will solve the immediate issue but I'm worried about other similar target dependencies. No objection to checking it in but I'm not sure it'll fix everything.

[jjonescz]

I have actually seen some more non deterministic issues while having this fix locally, so we should probably solve differently. Thanks

[arkalyanms]

@jjonescz / @rainersigwald until the msbuild fix comes in from dotnet/msbuild#10306 (comment), can we publish and check this in?

[jjonescz]

I'm not 100% sure this won't cause other issues, but if you are observing the bug and can try this out locally to verify it works, then we can merge it.

cc @CyrusNajmabadi

[CyrusNajmabadi]

Unfortunately, this branch fails to build/restore. It causes:

[CyrusNajmabadi]

restore in VS is also failing:

Failed to restore D:\github\roslyn\src\Tools\BuildBoss\BuildBoss.csproj (in 21 ms).
Failed to restore D:\github\roslyn\src\Tools\ExternalAccess\RazorCompiler\Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler.csproj (in 22 ms).
Failed to restore D:\github\roslyn\src\Tools\AnalyzerRunner\AnalyzerRunner.csproj (in 22 ms).
Failed to restore D:\github\roslyn\src\Tools\GenerateRulesMissingDocumentation\GenerateRulesMissingDocumentation.csproj (in 21 ms).
Failed to restore D:\github\roslyn\src\Tools\ExternalAccess\Razor\Microsoft.CodeAnalysis.ExternalAccess.Razor.csproj (in 21 ms).
Failed to restore D:\github\roslyn\src\Features\Core\Portable\Microsoft.CodeAnalysis.Features.csproj (in 27 ms).
Failed to restore D:\github\roslyn\src\Tools\ExternalAccess\RazorCompilerTest\Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler.UnitTests.csproj (in 23 ms).
Failed to restore D:\github\roslyn\src\Features\ExternalAccess\AspNetCore\Microsoft.CodeAnalysis.ExternalAccess.AspNetCore.csproj (in 21 ms).
Failed to restore D:\github\roslyn\src\Tools\BuildValidator\BuildValidator.csproj (in 21 ms).

Causing major failures in VS:

[jjonescz]

Unfortunately, this branch fails to build/restore. It causes:

This branch is not up to date, please just try the change on latest main.

Those NU1010 errors were fixed by #74299.

[CyrusNajmabadi]

Have merged main in:

I get:

[CyrusNajmabadi]

@jjonescz What would you need to be able to move forward on this. Right now the core issue is preventing being able to dev in VS reasonably :( Thanks very much for your help!

[jjonescz]

From the picture it doesn't look like the latest main is merged in, I see #74291 as the last commit in the main you merged if I interpret the picture correctly. That doesn't have the fix from today. I have updated this branch with the latest main now.

[jjonescz]

What would you need to be able to move forward on this. Right now the core issue is preventing being able to dev in VS reasonably :( Thanks very much for your help!

If this workaround doesn't work, let me know, I can look again to see if there is a better workaround or if we can flow the internal fix here sooner.

[arkalyanms]

The internal fix is getting inserted into VS now via https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/563555. ETA tonight.

[jjonescz]

The internal fix is getting inserted into VS now via https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/563555. ETA tonight.

Don't we need the VSSDK packages to be updated in Roslyn? I've tried that in #74329 but tests are failing, it's outside my area of expertise.

[arkalyanms]

The internal fix is getting inserted into VS now via https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/563555. ETA tonight.

Don't we need the VSSDK packages to be updated in Roslyn? I've tried that in #74329 but tests are failing, it's outside my area of expertise.

Yes I ve sent the PR to the Extensibility team you validate the version that got published. In the meantime, we would want to work with our infra on test failures.

[jjonescz]

I'm not sure if we can easily update VSSDK, see #74329 (comment).

But from #74320 (comment) I understand this workaround works for @CyrusNajmabadi, so perhaps we can merge it in the meantime.