Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address PR feedback on https://github.com/dotnet/roslyn/pull/74132 #74193

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Address PR feedback on https://github.com/dotnet/roslyn/pull/74132 #74193

wants to merge 2 commits into from
+109 −68

Conversation

333fred
Copy link
Member

@333fred 333fred commented Jun 27, 2024

No description provided.

@333fred 333fred requested a review from a team as a code owner June 27, 2024 22:45
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 27, 2024
@333fred
Copy link
Member Author

333fred commented Jun 27, 2024

@jcouv @dotnet/roslyn-compiler for review. Followup from non-blocking comments on #74132.

@jcouv jcouv self-assigned this Jun 27, 2024
jcouv
jcouv reviewed Jun 27, 2024
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (iteration 1)

@333fred
Copy link
Member Author

333fred commented Jun 28, 2024

@jcouv @dotnet/roslyn-compiler for reviews

jcouv
jcouv approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@333fred
Copy link
Member Author

333fred commented Jun 28, 2024

@dotnet/roslyn-compiler for a second review.

@333fred
Copy link
Member Author

333fred commented Jul 2, 2024

@dotnet/roslyn-compiler for a second review please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@333fred @jcouv