-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for consuming instance extension methods from VB and previous version of C# compiler. #74182
Add tests for consuming instance extension methods from VB and previous version of C# compiler. #74182
Conversation
…us version of C# compiler.
} | ||
"""; | ||
|
||
#if !PREVIOUSVERSIONOFCOMPILER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's PREVIOUSVERSIONOFCOMPILER
? It's not defined anywhere as far as I can see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not defined anywhere as far as I can see.
That is the intent. The branch that is not taken reflects behavior of the compiler in main
. Obviously, it is going to fail in roles
. The tests can be run manually in `main' by copy/pasting them into a file and defining the conditional compilation symbol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider leaving a comment on one of those directives to provide context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider leaving a comment on one of those directives to provide context.
I will do this in a separate PR
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 1)
} | ||
"""; | ||
|
||
#if !PREVIOUSVERSIONOFCOMPILER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider leaving a comment on one of those directives to provide context.
No description provided.