Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for consuming instance extension methods from VB and previous version of C# compiler. #74182

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs AlekseyTs requested review from jjonescz and jcouv June 27, 2024 12:20
@AlekseyTs AlekseyTs requested a review from a team as a code owner June 27, 2024 12:20
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 27, 2024
@AlekseyTs
Copy link
Contributor Author

@jcouv, @jjonescz Please review

}
""";

#if !PREVIOUSVERSIONOFCOMPILER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's PREVIOUSVERSIONOFCOMPILER? It's not defined anywhere as far as I can see.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not defined anywhere as far as I can see.

That is the intent. The branch that is not taken reflects behavior of the compiler in main. Obviously, it is going to fail in roles. The tests can be run manually in `main' by copy/pasting them into a file and defining the conditional compilation symbol.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider leaving a comment on one of those directives to provide context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider leaving a comment on one of those directives to provide context.

I will do this in a separate PR

@AlekseyTs
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@AlekseyTs
Copy link
Contributor Author

@jcouv, @jjonescz, @dotnet/roslyn-compiler Please review

@AlekseyTs AlekseyTs requested review from jjonescz and a team June 28, 2024 18:12
@AlekseyTs
Copy link
Contributor Author

@jcouv, @jjonescz, @dotnet/roslyn-compiler Please review

@jcouv jcouv self-assigned this Jul 2, 2024
@jcouv jcouv added the Test Test failures in roslyn-CI label Jul 2, 2024
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

}
""";

#if !PREVIOUSVERSIONOFCOMPILER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider leaving a comment on one of those directives to provide context.

@AlekseyTs AlekseyTs merged commit 0d439ff into dotnet:features/roles Jul 3, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers New Language Feature - Roles Roles Test Test failures in roslyn-CI untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants