Code Fixup #1412
Open
Code Fixup #1412
+253
−297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalProcessBuilder.cs and ExternalProcessExecutor.cs
…er readability negated pattern reference : https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/operators/patterns
…sing '?' operator for merging if statement remove redundant semicolon
|
Hello, I reviewed the code and noticed something: in the SignTool module and in the JsonTypes.cs file, there are numerous constructors that are unnecessary and unused. They can be safely removed to clean up the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I hope you are well
Thank you for helping open source and building this project for the .NET community
Out of curiosity, I was reviewing the codes of this repository and I found some points that might be good to correct.
The next thing is that you can use the primary constructor according to the latest version of .NET
In some cases, we could have written the code in a more concise and readable manner and used expressions
I am endeavoring to that the latest features and updates in the .NET ecosystem are seamlessly integrated into the project without conflicts. It's my goal to contribute to the continuous improvement of this project.
I hope these things are helpful and I will be happy to contribute to the progress of this project
Please check and let me know the result