Only show element hover information when hovering over an element in a .razor file
#11336
+44
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgav
approved these changes
Dec 31, 2024
| // Filter out attribute descriptors since we're creating an element hover | ||
| var keepAttributeInfo = FileKinds.GetFileKindFromFilePath(documentFilePath) == FileKinds.Legacy; | ||
| var descriptionInfos = descriptors | ||
| .Where(d => keepAttributeInfo || !d.IsAttributeDescriptor()) |
There was a problem hiding this comment.
Seems a little wrong to execute the where clause at all when keepAttributeInfo is true, but probably not worth complicating the code since n is going to be low and perf savings small.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11335
Event callbacks on components use the tag helper infrastructure internally in the compiler, but it makes sense to me to have different rules applied to them when it comes to showing hover info. Leaving the existing code as is for
.cshtmlfiles is entirely deliberate.Before:
After:
