Update MicrosoftDotNetHotReloadPackageVersion and CPSPackageVersion #9802
+22
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o latest pre-release versions
tmat
approved these changes
Oct 3, 2025
drewnoakes
reviewed
Oct 6, 2025
There was a problem hiding this comment.
Why add this without any apparent usages? It's fine to add things like this, but better when they're actually used at the time they're added, so that we can tell it adds value to the code.
There was a problem hiding this comment.
This is required by the newer version of Microsoft.DotNet.HotReload.Client source package.
There was a problem hiding this comment.
Yes, HotReloadClients requires that extenion. It's from a source package so the change is not in the git history
public ValueTask ReportCompilationErrorsInApplicationAsync(ImmutableArray<string> compilationErrors, CancellationToken cancellationToken)
=> browserRefreshServer?.ReportCompilationErrorsInBrowserAsync(compilationErrors, cancellationToken) ?? ValueTask.CompletedTask;
There was a problem hiding this comment.
We can also update PolySharp to generate this extension code. For now I'd go with this change since it's simpler.
src/Microsoft.VisualStudio.ProjectSystem.Managed/ValueTaskExtension.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualStudio.ProjectSystem.Managed/ValueTaskExtension.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualStudio.ProjectSystem.Managed/ValueTaskExtension.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualStudio.ProjectSystem.Managed/ValueTaskExtension.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualStudio.ProjectSystem.Managed/ValueTaskExtension.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualStudio.ProjectSystem.Managed/ValueTaskExtension.cs
Outdated
Show resolved
Hide resolved
… and unnecessary preprocessor directives
tmat
approved these changes
Oct 6, 2025
drewnoakes
approved these changes
Oct 6, 2025
|
|
||
| namespace System.Threading.Tasks; | ||
|
|
||
| internal static partial class ValueTaskExtensions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o latest pre-release versions