Skip to content

Remove build parameter #9687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions eng/pipelines/official.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,6 @@ parameters:
displayName: Do Not Optimize Assemblies
type: boolean
default: false
- name: VisualStudioMinimumVersion
displayName: Visual Studio Minimum Version
type: string
default: '18'

###################################################################################################################################################################
# STAGES
Expand Down Expand Up @@ -146,7 +142,6 @@ extends:
InsertionVSBranch: ${{ parameters.InsertionVSBranch }}
CreateVSGreenInsertion: ${{ parameters.CreateVSGreenInsertion }}
InsertionVSGreenBranch: ${{ parameters.InsertionVSGreenBranch }}
VisualStudioMinimumVersion: ${{ parameters.VisualStudioMinimumVersion }}
- stage: Publish
displayName: Publish
dependsOn: Build
Expand Down
5 changes: 1 addition & 4 deletions eng/pipelines/templates/build-official-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ parameters:
type: boolean
- name: InsertionVSGreenBranch
type: string
- name: VisualStudioMinimumVersion
type: string
default: '17'

jobs:
- job: BuildOfficialRelease
Expand Down Expand Up @@ -192,7 +189,7 @@ jobs:
displayName: Build VS Bootstrapper
inputs:
bootstrapperCoreVersion: latest
vsMajorVersion: ${{ parameters.VisualStudioMinimumVersion }}
vsMajorVersion: $(SetVisualStudioMinimumVersionVariable.VisualStudioMinimumVersion)
channelName: int.main
manifests: $(Build.SourcesDirectory)/artifacts/$(BuildConfiguration)/VSSetup/Insertion/SetupManifest.vsman
# Outputting to the Insertion folder allows the bootstrapper to be published to the Products drop, along with our insertion files.
Expand Down
2 changes: 1 addition & 1 deletion version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/main/src/NerdBank.GitVersioning/version.schema.json",
"version": "17.14",
"version": "18.0",
"cloudBuild": {
"setAllVariables": true
}
Expand Down
Loading