Skip to content

Revert "[vs18.12] Update dependencies from dotnet/arcade" - #15234

Merged
VolPlita merged 1 commit into
vs18.12from
revert-15197-darc-vs18.12-c5f87ce2-be9f-4b15-a2e9-4b6b945851b4
Oct 9, 2026
Merged

VolPlita merged 1 commit into
vs18.12from
revert-15197-darc-vs18.12-c5f87ce2-be9f-4b15-a2e9-4b6b945851b4

Conversation

@JanProvaznik

Copy link
Copy Markdown
Member

Reverts #15197

breaks official build and we need to have it ready before dotnet/arcade#17683 flows

@JanProvaznik
JanProvaznik requested a review from a team as a code owner October 9, 2026 11:17
Copilot AI balanced review requested due to automatic review settings October 9, 2026 11:17
@JanProvaznik
JanProvaznik deployed to copilot-pat-pool October 9, 2026 11:17 — with GitHub Actions Active
@JanProvaznik
JanProvaznik deployed to copilot-pat-pool October 9, 2026 11:17 — with GitHub Actions Active
@JanProvaznik
JanProvaznik deployed to copilot-pat-pool October 9, 2026 11:18 — with GitHub Actions Active

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes exactly reverse the identified dependency update and consistently restore the prior build infrastructure state.

0 open findings

What changed in this PR

Temporarily rolls back the Arcade dependency update that broke official builds, pending the upstream Arcade fix.

Changes:

  • Downgrades Arcade SDK and xUnit extensions to 11.0.0-beta.26469.4.
  • Restores the prior GitHub App token and OneLoc templates.
  • Restores opt-in fully qualified Helix test names.
File Description
global.json Restores the previous Arcade SDK.
eng/​Version.Details.xml Restores dependency versions and SHAs.
eng/​Version.Details.props Restores generated package versions.
eng/​common/​Get-GitHubAppToken.ps1 Restores Key Vault signing behavior.
eng/​common/​core-templates/​steps/​get-github-app-token.yml Restores token-step parameters.
eng/​common/​core-templates/​job/​onelocbuild.yml Restores OneLoc authentication settings.
eng/​common/​core-templates/​job/​helix-job-monitor.yml Restores the test-name default.

🧠 Review effort: Balanced


💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@JanProvaznik
JanProvaznik deployed to copilot-pat-pool October 9, 2026 11:29 — with GitHub Actions Active
@JanProvaznik
JanProvaznik deployed to copilot-pat-pool October 9, 2026 11:30 — with GitHub Actions Active

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 24/24 dimensions clean — no findings.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • raw.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "raw.githubusercontent.com"

See Network Configuration for more information.

Generated by Expert Code Review (on open) for #15234 · copilot · gpt56 · 445.3 AIC · ⌖ 0.504 AIC · ⊞ 24.9K

@JanProvaznik
JanProvaznik deployed to copilot-pat-pool October 9, 2026 11:31 — with GitHub Actions Active
@VolPlita
VolPlita merged commit 5d08fa8 into vs18.12 Oct 9, 2026
19 checks passed
@VolPlita
VolPlita deleted the revert-15197-darc-vs18.12-c5f87ce2-be9f-4b15-a2e9-4b6b945851b4 branch October 9, 2026 13:25

This branch was successfully deployed

1 active deployment
copilot-pat-pool — 9c992dea Deployed Oct 9, 2026 by JanProvaznik via conclusion #980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants