Repository navigation
Conversation
This reverts commit 400aabe.
There was a problem hiding this comment.
🟢 Approval recommended
The changes exactly reverse the identified dependency update and consistently restore the prior build infrastructure state.
0 open findings
What changed in this PR
Temporarily rolls back the Arcade dependency update that broke official builds, pending the upstream Arcade fix.
Changes:
- Downgrades Arcade SDK and xUnit extensions to
11.0.0-beta.26469.4. - Restores the prior GitHub App token and OneLoc templates.
- Restores opt-in fully qualified Helix test names.
| File | Description |
|---|---|
global.json |
Restores the previous Arcade SDK. |
eng/Version.Details.xml |
Restores dependency versions and SHAs. |
eng/Version.Details.props |
Restores generated package versions. |
eng/common/Get-GitHubAppToken.ps1 |
Restores Key Vault signing behavior. |
eng/common/core-templates/steps/get-github-app-token.yml |
Restores token-step parameters. |
eng/common/core-templates/job/onelocbuild.yml |
Restores OneLoc authentication settings. |
eng/common/core-templates/job/helix-job-monitor.yml |
Restores the test-name default. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
✅ 24/24 dimensions clean — no findings.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
raw.githubusercontent.com
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "raw.githubusercontent.com"See Network Configuration for more information.
Generated by Expert Code Review (on open) for #15234 · copilot · gpt56 · 445.3 AIC · ⌖ 0.504 AIC · ⊞ 24.9K
Reverts #15197
breaks official build and we need to have it ready before dotnet/arcade#17683 flows