Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend property assignment event #11106

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Dec 6, 2024

Fixes #2711
and connected to KirillOsenkov/MSBuildStructuredLog#839

Context

This implementation covers cases:

  • property coming from a command-line argument (e.g. /p:) (previously had a Global source)
  • as an output of a target
  • as an output of a task
  • exact property location if it comes from xml during evaluation

Also, the message formatting logic was changed for PropertyReassignmentEventArgs and PropertyInitialValueSetEventArgs to have it optimized for existing deduplication logic.
The event save all the unique data and format it on the receiving side (e.g. LogViewer).

The measurements were taken for the latest OrchardCode

No property init/reassignment logged Property init/reassignment logged
Binlog Size 162.932 KB 196.269 KB
Build Time 533.4s 579.0s
BinLog allocations Total opening time: 1:00.416, Loading: 27.490 s, Analyzing: 7.036 s, Indexing: 21.540 s, Reading files: 400 ms, Allocated: 35,920,765,696 bytes, Nodes: 219,551,777, Strings: 436,574 Total opening time: 1:28.087, Loading: 39.449 s, Analyzing: 6.991 s, Indexing: 37.275 s, Reading files: 403 ms, Allocated: 39,507,530,416 bytes, Nodes: 224,560,814, Strings: 489,542

Conclusions:

Metric Analysis
Binlog Size The binlog size increased from 162.932 KB to 196.269 KB, an increase of about 20%.
Build Time The build time increased from 533.4s to 579.0s, an increase of approximately 8.5%.
BinLog allocations Memory Allocation: Increased from ~35.9 GB to ~39.5 GB (+10% memory usage), Node and String Count: Nodes increased by 2.3% and Strings increased by 12.1%, Loading time increased significantly (from 27.5s to 39.4s), Indexing time increased (from 21.5s to 37.3s)

@YuliiaKovalova YuliiaKovalova marked this pull request as ready for review December 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log how properties are initially assigned
1 participant