[iOS] Fix for Slider ThumbImageSource is not centered properly on iOS 26#34019
Draft
HarishwaranVijayakumar wants to merge 3 commits intodotnet:mainfrom
Draft
[iOS] Fix for Slider ThumbImageSource is not centered properly on iOS 26#34019HarishwaranVijayakumar wants to merge 3 commits intodotnet:mainfrom
HarishwaranVijayakumar wants to merge 3 commits intodotnet:mainfrom
Conversation
Contributor
|
Hey there @@HarishwaranVijayakumar! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
ThumbImageSourceis set on a Slider control at runtime, the thumb image is not vertically centered on the slider track. The image appears offset (positioned incorrectly).Root Cause of the issue
Description of Change
SliderExtensions.cs, after callingSetThumbImage, the code now explicitly callsSetNeedsLayout()on theUISliderfor iOS 26 and above to ensure the thumb position is recalculated, restoring previous runtime behavior.Issues Fixed
Fixes #33967
Tested the behaviour in the following platforms
Output