Open
Conversation
rmarinho
added
the
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI pipeline to run Android tests on a Linux-based pool (MAUI-DNCENG with 1ESPT-Ubuntu22.04) instead of macOS pools.
Changes:
- Added a new
AndroidPoolLinuxpipeline parameter describing the Linux pool + demands. - Updated the
mac_runandroid_testsstage to useAndroidPoolLinuxfor both PR and non-PR runs.
| @@ -277,12 +284,9 @@ stages: | |||
| # TODO: macOSTemplates and AOT template categories | |||
| - name: mac_runandroid_tests | |||
There was a problem hiding this comment.
The stage name mac_runandroid_tests is now misleading since it runs on a Linux pool. Consider renaming it to something platform-neutral (e.g., runandroid_tests) or explicitly Linux-based (e.g., linux_runandroid_tests) to avoid confusion when diagnosing CI failures.
Suggested change
| - name: mac_runandroid_tests | |
| - name: linux_runandroid_tests |
Member
Author
Member
Author
|
@copilot can you figure how we can install maui-android instead of maui when running mac_runandroid_tests since this a linux ? i think uitests do this , can you saw how it is done on those pipelines? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request updates the CI pipeline configuration to introduce and use a new Linux-based pool for running Android tests, replacing the previous macOS-based pools. The main changes are the addition of the
AndroidPoolLinuxparameter and updating the relevant test stage to use this new pool.Pipeline configuration updates:
AndroidPoolLinuxparameter toparameters:ineng/pipelines/ci.ymlfor specifying a Linux pool (MAUI-DNCENG) with the1ESPT-Ubuntu22.04image for Android test runs.mac_runandroid_testsstage to use the newAndroidPoolLinuxpool instead of the previous macOS-based pools, ensuring Android tests run on Linux infrastructure.