-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Simplify iOS ScrollView - improvement #26893
base: main
Are you sure you want to change the base?
Conversation
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
@albyrock87 could you please take a look :) |
@kubaflo good catch.. this use case was totally missing from UI tests. If you could add a UI test which covers this it'd be great! The fix itself looks good to me. |
@albyrock87 sure! I will add a UI test soon |
@albyrock87 I've just added a test :) |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
I think, I've identified a potential regression related to the simplified ScrollView on iOS (#26763). The issue occurs when an explicit HeightRequest is set on the ScrollView. In such cases, the content of the ScrollView is restricted to the specified height, which prevents scrolling as intended.
Issues Fixed
Fixes #26900
Screen.Recording.2025-01-01.at.02.26.16.mov
Screen.Recording.2025-01-01.at.02.32.19.mov