Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix for MenuFlyoutItems programmatically added to MenuFlyoutSubItems are not visible #26886

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman commented Dec 31, 2024

Root Cause of the issue

  • If the parent PlatformView of MenuFlyoutSubItem is MenuBarItem, it does not retrieve the items in the Reset method of the MenuFlyoutSubItemHandler on Windows. As a result, it is null, and subsequent item insertions are not processed.

Description of Change

  • Add a condition to check if the PlatformView is a MenuBarItem. If it is, retrieve the items and process the remaining logic in the Reset method of the MenuFlyoutSubItemHandler on Windows and works fine

Issues Fixed

Fixes #26856

Tested the behaviour in the following platforms

  • Windows
  • Android
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix
MenuFlyoutItemsIssue.mp4
MenuFlyoutItemsFix.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 31, 2024
Copy link
Contributor

Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 31, 2024
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review January 2, 2025 14:27
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner January 2, 2025 14:27
@Redth
Copy link
Member

Redth commented Jan 2, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MenuFlyoutItems programmatically added to MenuFlyoutSubItems are not visible.
2 participants