[Windows] Tap Events Incorrectly passed Through Button - fix #26834
+193
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyIX
changed the title
MartyIX
force-pushed
the
feature/2024-12-26-Windows-Click-through
branch
from
c1e1c2f to
5cc8f85
Compare
MartyIX
requested review from
Foda
and removed request for
StephaneDelcroix and
tj-devel709
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
MartyIX
force-pushed
the
feature/2024-12-26-Windows-Click-through
branch
2 times, most recently
from
9872c1c to
52320be
Compare
MartyIX
force-pushed
the
feature/2024-12-26-Windows-Click-through
branch
from
52320be to
aa3c96d
Compare
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Failed tests look unrelated. I rerun locally |
MartyIX
force-pushed
the
feature/2024-12-26-Windows-Click-through
branch
from
aa3c96d to
6aea414
Compare
|
Pushed to fix merge conflict. |
Foda
approved these changes
Jan 2, 2025
MartyIX
commented
Jan 2, 2025
| @@ -783,8 +864,17 @@ void UpdatingGestureRecognizers() | |||
| || children?.GetChildGesturesFor<TapGestureRecognizer>(g => g.NumberOfTapsRequired == 1).Any() == true) | |||
| { | |||
| _subscriptionFlags |= SubscriptionFlags.ContainerTapAndRightTabEventSubscribed; | |||
| _tappedEventHandler = new TappedEventHandler(OnTap); | |||
| _container.AddHandler(FrameworkElement.TappedEvent,_tappedEventHandler, true); | |||
There was a problem hiding this comment.
See #26640 (comment). I tested setting this true to false but it did not work for me then. That's why I tried the "special-casing" approach.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#25311 makes it possible to register when an entry is tapped. However, it seems it breaks other controls.
This is, in a way, naive way to fix it by "special-casing" (see the third commit) #25311's behavior just for entries and not other controls.
Notes:
Issues Fixed
Fixes #26640