Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced BeginnersSeries sample (MauiApp2) to be more beginner's friendly #439

Merged

Conversation

tscholze
Copy link
Contributor

Motivation
I'm currently learning and playing around with .NET MAUI. I really like the samples in this repository.

In my eyes as an absolute beginner, the code could be a little bit enhanced to be more friendly for first-timers in the MAUI ecosystem.

Besides this, I renamed sample to avoid generic MauiApp2 and be more aligned with other samples in its naming.

Changes

  • Updated solution, project and namespace to 'BeginnersTask' to be aligned with other samples naming structure
  • Fixed missing indents
  • Added comment to MauiProgram.cs with helpful links to Microsoft Learn
  • Added comment to MainViewModel.cs with helpful code pointers to see related setups and receivers of routings

…ndly

- Updated solution, project and namespace to 'BeginnersTask' to be aligned with other samples naming structure
- Fixed missing indents
- Added comment to MauiProgram.cs with helpful links to Microsoft Learn
- Added comment to MainViewModel.cs with helpful code pointers to see related setups and receivers of routings
@tscholze
Copy link
Contributor Author

@microsoft-github-policy-service agree

@tscholze
Copy link
Contributor Author

@microsoft-github-policy-service rerun

@jfversluis jfversluis closed this Feb 20, 2024
@jfversluis jfversluis reopened this Feb 20, 2024
@jfversluis
Copy link
Member

@microsoft-github-policy-service rerun

@davidbritch davidbritch reopened this Feb 21, 2024
@tscholze
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Contributor

@davidbritch davidbritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @tscholze

@davidbritch davidbritch merged commit 3bc23ba into dotnet:main Feb 21, 2024
7 checks passed
@tscholze tscholze deleted the t.scholze/enhance-beginners-task-sample branch February 21, 2024 10:59
@tscholze
Copy link
Contributor Author

You are welcome @davidbritch - thanks for accepting such minor changes - it feels awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants