Skip to content

Commit

Permalink
Fix build and some minor improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
jfversluis committed Nov 27, 2024
1 parent b7c416a commit 8bdb326
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 7 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/build-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@ jobs:

- name: Install .NET MAUI Workload
run: dotnet workload install maui
# if: runner.os == 'macOS' # reenable when .NET 8 is default on hosted runners

- name: Select Xcode Version
run: sudo xcode-select -s /Applications/Xcode_16.1.app
run: sudo xcode-select -s /Applications/Xcode_16.0.app
if: runner.os == 'macOS'

- name: Find and build all C# projects
Expand Down Expand Up @@ -75,7 +74,12 @@ jobs:
$proj_dir = [System.IO.Path]::GetDirectoryName($csproj)
Write-Output "Cleaning up bin & obj in $proj_dir"
Get-ChildItem -Path $proj_dir -Directory -Recurse -Include bin,obj | Remove-Item -Recurse -Force
try {
Get-ChildItem -Path $proj_dir -Directory -Recurse -Include bin,obj | Remove-Item -Recurse -Force
} catch {
Write-Output "::warning:: Failed to clean up bin & obj in $proj_dir"
}
Write-Output "::endgroup::"
}
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/build-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,9 @@ jobs:

- name: Install .NET MAUI Workload
run: dotnet workload install maui
# if: runner.os == 'macOS' # reenable when .NET 8 is default on hosted runners

- name: Select Xcode Version
run: sudo xcode-select -s /Applications/Xcode_16.1.app
run: sudo xcode-select -s /Applications/Xcode_16.0.app
if: runner.os == 'macOS'

- name: Find and build changed projects
Expand Down Expand Up @@ -112,7 +111,12 @@ jobs:
$proj_dir = [System.IO.Path]::GetDirectoryName($projectToBuild)
Write-Output "Cleaning up bin & obj in $proj_dir"
Get-ChildItem -Path $proj_dir -Directory -Recurse -Include bin,obj | Remove-Item -Recurse -Force
try {
Get-ChildItem -Path $proj_dir -Directory -Recurse -Include bin,obj | Remove-Item -Recurse -Force
} catch {
Write-Output "::warning:: Failed to clean up bin & obj in $proj_dir"
}
Write-Output "::endgroup::"
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="31" />
<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="35" />
<application android:allowBackup="true" android:icon="@mipmap/appicon" android:roundIcon="@mipmap/appicon_round" android:supportsRtl="true"></application>
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
</manifest>

0 comments on commit 8bdb326

Please sign in to comment.