[RGen] Update the BindingAttribute to allow to pass the type for a category. #23358

mandel-macaque · 2025-07-18T22:31:03Z

This allows to pass the type rather than the name of the type which is a safer approach since the compiler will help us. The creation of a Category will now look like:

[Binding<Category>(typeof (NSObject))]
public static class MyCategory {
  // static extension methods
}

…tegory. This allows to pass the type rather than the name of the type which is a safer approach since the compiler will help us. The creation of a Category will now look like: ```csharp [Bindin<Category>(typeof (NSObject))] public static class MyCategory { // static extension methods } ```

Copilot

Pull Request Overview

This PR enhances the BindingAttribute to support passing types directly for category definitions rather than just string names, providing compile-time type safety. The key improvement allows developers to use [Binding<Category>(typeof(NSObject))] instead of string-based category definitions.

Adds support for Type parameters in BindingTypeAttribute constructors for categories
Updates BindingTypeData to handle TypeInfo objects for category type information
Modifies parsing logic to differentiate between category and class binding scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/ObjCBindings/BindingTypeAttribute.cs	Adds CategoryType property and new constructors accepting Type parameters
src/rgen/Microsoft.Macios.Generator/Attributes/BindingTypeData.cs	Implements CategoryType support with TypeInfo, updates parsing logic, and adds comprehensive documentation
tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/BindingInfoTests.cs	Updates test expectations to include CategoryType field in string representations

Copilot · 2025-07-18T22:31:37Z

src/rgen/Microsoft.Macios.Generator/Attributes/BindingTypeData.cs

@@ -266,11 +435,23 @@ public override int GetHashCode ()
 		return HashCode.Combine (Name, Flags);


The GetHashCode method does not include CategoryType in the hash calculation, but CategoryType is used in the Equals method. This violates the contract that objects that are equal must have the same hash code.

Suggested change

return HashCode.Combine (Name, Flags);

return HashCode.Combine (Name, Flags, CategoryType);

Copilot · 2025-07-18T22:31:38Z

src/rgen/Microsoft.Macios.Generator/Attributes/BindingTypeData.cs

@@ -220,26 +372,41 @@ public static bool TryParse (AttributeData attributeData,
 				stringCtorVisibility = (MethodAttributes) Convert.ToSingle ((int) value.Value!);


Using Convert.ToSingle to cast to MethodAttributes is incorrect. This should be a direct cast: (MethodAttributes)(int)value.Value! since MethodAttributes is an enum with int underlying type.

vs-mobiletools-engineering-service2 · 2025-07-19T04:43:32Z

✅ [CI Build #42b58d6] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 42b58d6fd465adcd4c981bf5c2cd454774608ac9 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-19T04:46:18Z

✅ [PR Build #42b58d6] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 42b58d6fd465adcd4c981bf5c2cd454774608ac9 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-19T05:12:38Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 42b58d6fd465adcd4c981bf5c2cd454774608ac9 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-19T05:14:02Z

✅ [CI Build #42b58d6] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 42b58d6fd465adcd4c981bf5c2cd454774608ac9 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-19T05:24:51Z

💻 [CI Build #42b58d6] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 42b58d6fd465adcd4c981bf5c2cd454774608ac9 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-19T05:25:54Z

💻 [CI Build #42b58d6] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 42b58d6fd465adcd4c981bf5c2cd454774608ac9 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-19T05:27:14Z

💻 [CI Build #42b58d6] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 42b58d6fd465adcd4c981bf5c2cd454774608ac9 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-19T05:27:28Z

💻 [CI Build #42b58d6] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 42b58d6fd465adcd4c981bf5c2cd454774608ac9 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-19T06:29:26Z

🔥 [CI Build #42b58d6] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 125 tests passed.

Failures

❌ monotouch tests (macOS)

1 tests failed, 11 tests passed.

monotouch-test/macOS/Debug (static registrar, ARM64): TimedOut (Execution timed out after 1200 seconds.
Test run crashed)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 42b58d6fd465adcd4c981bf5c2cd454774608ac9 [PR build]

mandel-macaque · 2025-07-21T12:17:59Z

Failing tests are unrelated to code changes.

mandel-macaque requested a review from Copilot July 18, 2025 22:31

Copilot AI reviewed Jul 18, 2025

View reviewed changes

Auto-format source code

f288f4e

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/mandel/binding-attr-category-type

42b58d6

rolfbjarne approved these changes Jul 21, 2025

View reviewed changes

mandel-macaque merged commit 73f184e into main Jul 21, 2025
42 of 44 checks passed

mandel-macaque deleted the dev/mandel/binding-attr-category-type branch July 21, 2025 12:18

		@@ -266,11 +435,23 @@ public override int GetHashCode ()
		return HashCode.Combine (Name, Flags);

	return HashCode.Combine (Name, Flags);
	return HashCode.Combine (Name, Flags, CategoryType);

		@@ -220,26 +372,41 @@ public static bool TryParse (AttributeData attributeData,
		stringCtorVisibility = (MethodAttributes) Convert.ToSingle ((int) value.Value!);

[RGen] Update the BindingAttribute to allow to pass the type for a category. #23358

[RGen] Update the BindingAttribute to allow to pass the type for a category. #23358

Uh oh!

Conversation

mandel-macaque commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 19, 2025

✅ [CI Build #42b58d6] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 19, 2025

✅ [PR Build #42b58d6] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 19, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 19, 2025

✅ [CI Build #42b58d6] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 19, 2025

💻 [CI Build #42b58d6] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 19, 2025

💻 [CI Build #42b58d6] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 19, 2025

💻 [CI Build #42b58d6] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 19, 2025

💻 [CI Build #42b58d6] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 19, 2025

🔥 [CI Build #42b58d6] Test results 🔥

Test results

Failures

❌ monotouch tests (macOS)

Successes

Uh oh!

mandel-macaque commented Jul 21, 2025

Uh oh!

Uh oh!

Uh oh!

mandel-macaque commented Jul 18, 2025 •

edited

Loading