-
Notifications
You must be signed in to change notification settings - Fork 540
[msbuild] Don't execute the ParseDeviceSpecificBuildInformation task on Mac Catalyst. #22887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…on Mac Catalyst. The 'ParseDeviceSpecificBuildInformation' task is only applicable to mobile targets (iOS and tvOS), so skip running it on Mac Catalyst (like we're already doing for macOS). This fixes a build error if happens to run on Mac Catalyst: > The "ParseDeviceSpecificBuildInformation" task failed unexpectedly. System.InvalidOperationException: Invalid platform: MacCatalyst Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2484312.
…on task on Mac Catalyst." This reverts commit c0e5a1b to test the new test to see if it fails.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ion task on Mac Catalyst." This reverts commit b5407a2.
✅ [CI Build #4fee50a] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #4fee50a] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #4fee50a] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #4fee50a] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #4fee50a] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #4fee50a] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #4fee50a] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #4fee50a] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 121 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
…ecificBuildInformation task on Mac Catalyst. (#22915) The 'ParseDeviceSpecificBuildInformation' task is only applicable to mobile targets (iOS and tvOS), so skip running it on Mac Catalyst (like we're already doing for macOS). This fixes a build error if happens to run on Mac Catalyst: > The \"ParseDeviceSpecificBuildInformation\" task failed unexpectedly. System.InvalidOperationException: Invalid platform: MacCatalyst Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2484312. Backport of #22887.
The 'ParseDeviceSpecificBuildInformation' task is only applicable to mobile
targets (iOS and tvOS), so skip running it on Mac Catalyst (like we're already
doing for macOS).
This fixes a build error if happens to run on Mac Catalyst:
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2484312.