Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 4.0.1 #7312

Open
wants to merge 1 commit into
base: release/4.0
Choose a base branch
from
Open

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Nov 14, 2024

No description provided.

@@ -7,8 +7,7 @@

<PropertyGroup>
<MajorVersion>$([MSBuild]::Subtract($(MajorVersion), 3))</MajorVersion>
<!-- Blank version for now for API compat -->
<PackageValidationBaselineVersion></PackageValidationBaselineVersion>
<PackageValidationBaselineVersion>$(MajorVersion).$(MinorVersion).$([MSBuild]::Subtract($(PatchVersion), 1))</PackageValidationBaselineVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$([MSBuild]::Subtract($(PatchVersion), 1)

This looks ok but I am wondering if we can always use 0 for the patch version here?

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.88%. Comparing base (972c994) to head (6c08c62).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/4.0    #7312      +/-   ##
===============================================
- Coverage        68.88%   68.88%   -0.01%     
===============================================
  Files             1470     1470              
  Lines           274005   274005              
  Branches         28403    28403              
===============================================
- Hits            188755   188752       -3     
- Misses           77927    77936       +9     
+ Partials          7323     7317       -6     
Flag Coverage Δ
Debug 68.88% <ø> (-0.01%) ⬇️
production 63.30% <ø> (-0.01%) ⬇️
test 89.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants