Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libmf submodule and reenable CodeQL on it #7159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented May 23, 2024

No description provided.

@ericstj
Copy link
Member Author

ericstj commented May 23, 2024

Looks like we now have some warnings as errors on x86. That's noticing our intentional truncation - where before the truncation happened in the loop bounds as potentially infiinite loop. I'll need to make another change to libmf to fix this.

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.65%. Comparing base (4d1a8c0) to head (6a03258).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7159      +/-   ##
==========================================
- Coverage   68.92%   68.65%   -0.27%     
==========================================
  Files        1396     1262     -134     
  Lines      266745   257767    -8978     
  Branches    27560    26660     -900     
==========================================
- Hits       183849   176976    -6873     
+ Misses      75792    73978    -1814     
+ Partials     7104     6813     -291     
Flag Coverage Δ
Debug 68.65% <ø> (-0.27%) ⬇️
production 62.93% <ø> (-0.59%) ⬇️
test 88.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 142 files with indirect coverage changes

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll approve for now but still need the x86 fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants