Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to control GPIO pins within rootless Docker container on Ra… #2276

Merged
merged 15 commits into from
Apr 5, 2024

Conversation

mu88
Copy link
Contributor

@mu88 mu88 commented Feb 9, 2024

Relates to #2169

Dear @Ellerbach,

I kindly ask you for your feedback regarding the new page "Control GPIO pins within rootless Docker container on Raspberry Pi".

Since I'm not a native English speaker, I also appreciate feedback regarding certain sentences/words that might sound "bumpy" 🙂

Last but not least, maybe we can consider whether it's worth asking somebody from the "rootless Docker .NET" world like Rich Landers for his feedback 🤔 just to be on the safe side that I'm not writing anything wrong.

Microsoft Reviewers: Open in CodeFlow

@mu88
Copy link
Contributor Author

mu88 commented Feb 9, 2024

@dotnet-policy-service agree

@Ellerbach
Copy link
Member

azp /run

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is really useful for people in the same situation as you. I made couple of suggestions while reading to have you gaining time with the linter ;-)
Otherwise, as already exchange on the topic in the issue, things look clear to me.

Documentation/raspi-Docker-GPIO.md Show resolved Hide resolved
Documentation/raspi-Docker-GPIO.md Show resolved Hide resolved
Documentation/raspi-Docker-GPIO.md Show resolved Hide resolved
Documentation/raspi-Docker-GPIO.md Show resolved Hide resolved
Documentation/raspi-Docker-GPIO.md Show resolved Hide resolved
Documentation/raspi-Docker-GPIO.md Show resolved Hide resolved
Documentation/raspi-Docker-GPIO.md Show resolved Hide resolved
Documentation/raspi-Docker-GPIO.md Show resolved Hide resolved
Documentation/raspi-Docker-GPIO.md Show resolved Hide resolved
Documentation/raspi-Docker-GPIO.md Show resolved Hide resolved
@pgrawehr
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the linter result and check if anything is left!

Documentation/raspi-Docker-GPIO.md Show resolved Hide resolved
@Ellerbach
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ellerbach
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mu88
Copy link
Contributor Author

mu88 commented Feb 16, 2024

Is there anything that I can do regarding the failed builds?

@Ellerbach
Copy link
Member

Is there anything that I can do regarding the failed builds?

From the build, I can see 1 broken link in one of the file. Can you just remove it as it doesn't really seems to exist anymore? Bonus point if you find a replacement link. Then good to go!

@mu88
Copy link
Contributor Author

mu88 commented Feb 19, 2024

/azp run

Copy link

Commenter does not have sufficient privileges for PR 2276 in repo dotnet/iot

@Ellerbach
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mu88
Copy link
Contributor Author

mu88 commented Feb 22, 2024

Is there anything I can help you with regarding the failing builds, @Ellerbach ?

@Ellerbach
Copy link
Member

Is there anything I can help you with regarding the failing builds, @Ellerbach ?

No, it's just failing for an unknown reason. Let's see if we merge it like this as all is correct. We do have a triage call on Thursday.

@Ellerbach
Copy link
Member

/azp run

Copy link

Pull request contains merge conflicts.

@Ellerbach
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ellerbach Ellerbach merged commit b9a4d06 into dotnet:main Apr 5, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants