Perf: async project invalidation + debounce script updateProjectOptions - #20126
Open
xperiandri wants to merge 2 commits into
Open
Perf: async project invalidation + debounce script updateProjectOptions#20126xperiandri wants to merge 2 commits into
updateProjectOptions#20126xperiandri wants to merge 2 commits into
Conversation
xperiandri
changed the title
updateProjectOptions
…1 resumable-code composition error; async invalidation via cancellableTask and stable emitCache for C# PE references
github-actions
Bot
added
the
AI-Tooling-Check-Scanned-Clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two perf fixes in
FSharpProjectOptionsManager.fs:.ResultblocksMailboxProcessorthread inFSharpProjectOptionsManager#20125 —.Resultblocking calls inhasDependentVersionChanged/isProjectInvalidatedwere blocking the single-threadedMailboxProcessorloop. Converted to asynccancellableTaskflow.updateProjectOptions(fires on every caret move) #20124 — scriptupdateProjectOptionsfired on every caret move. Added a 500ms debounce using a swappedCancellationTokenSourceandTask.Delay.Testing
Built successfully; deployed and validated in RoslynDev hive with CPU profiling.