Cache DocumentDiagnosticAnalyzer results by version stamp to avoid redundant typecheck on unchanged documents - #20121
Open
xperiandri wants to merge 1 commit into
Conversation
…recomputing diagnostics when document/project version is unchanged
DocumentDiagnosticAnalyzer results by version stamp to avoid redundant typecheck on unchanged documents
xperiandri
marked this pull request as ready for review
August 3, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20120
Summary
FSharpDocumentDiagnosticAnalyzer.GetDiagnosticspreviously recomputed syntax/semantic diagnostics (parse, typecheck,UnusedParentheses) on every crawler pass, even when the document text and project state had not changed since the last computation.This adds a version-stamp-aware cache keyed by
struct (DocumentId * DiagnosticsType), storing the last computed(textVersion, projectVersion, ImmutableArray<Diagnostic>)tuple:Syntaxdiagnostics, only the documenttextVersionis tracked (projectVersionusesVersionStamp.Default).Semanticdiagnostics, bothtextVersionanddocument.Project.GetDependentVersionAsync()are tracked.UnnecessaryParenthesesDiagnosticAnalyzerwork entirely.This mirrors the versioned-cache pattern used for referenced-project compilation emission in
FSharpProjectOptionsManager.fs(emitCache).Testing
dotnet build vsintegration/src/FSharp.Editor/FSharp.Editor.fsproj -c Debug— succeeded.Build.cmd -c Debug -deployExtensions) and validated with a CPU trace ofdevenv.exe.