Add Oxpecker repository to build check - #20065
Open
Lanayx wants to merge 7 commits into
Open
Conversation
Contributor
✅ No release notes required |
github-actions
Bot
added
the
⚠️ Affects-Build-Infra
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
CI fails at I've no idea why, locally it builds fine with 10.0.100 or later |
Contributor
It loads ns20 FSharp.Core which has no IAD support. |
Contributor
Author
This doesn't make sense, all Oxpecker projects target .NET 10, so ns21 should be chosen, not ns20. |
Contributor
|
I think it's the shims to use local compiler in the CI, they probably add the reference to ns20 library. That msbuild prefers it is another story. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…Core
The regression-test harness referenced the netstandard2.0 FSharp.Core for every
consuming project. A net5.0+/.NET 10 project resolves the FSharp.Core NuGet
package to its netstandard2.1 assembly, which (unlike netstandard2.0) exposes the
IAsyncDisposable-based task-builder 'Using' overload. Forcing netstandard2.0 broke
Oxpecker projects that use 'use'/'use!' with IAsyncDisposable inside task { }.
Select the FSharp.Core assembly the way NuGet would (netstandard2.0 for .NET
Framework/netstandard2.0 consumers, netstandard2.1 otherwise). The reference is
added in a target so TargetFramework is known, and runs before ResolvePackageAssets
so it still wins package conflict resolution over any transitively pulled FSharp.Core.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…NU1902/NU1903 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
⚠️ Affects-Restore
This comment has been minimized.
This comment has been minimized.
…Bug4861) The module used the no-op RunTestCasesInSequence marker, so its #r/#load script tests ran concurrently with other collections while sharing the global checker and process-global reference resolver. This intermittently dropped closure diagnostics, causing ExactlyOneError.Bug4861 to observe 0 diagnostics for a missing '#r' reference. Use the NotThreadSafeResourceCollection (DisableParallelization) like other reference-resolution-sensitive test modules. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…termittent MSB4057 The EndToEndBuildTests job runs '.\Build.cmd -c Release -pack' without -ci, so Arcade treats it as a local build and re-enables UpdateXlfOnBuild. This intermittently fails on the multi-targeted FSharp.Core build with: error MSB4057: The target "UpdateXlf" does not exist in the project. [TargetFramework=netstandard2.1] (dotnet#19961). Updating xlf files is never needed in CI, so disable it for this step, matching the existing pattern used by tests/ILVerify/ilverify.ps1. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
added
⚠️ Affects-Test-Tooling
Contributor
|
🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Restore
|
Member
|
@copilot resolve the merge conflicts in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Oxpecker repository to build check to prevent issues like #20059