Skip to content

fix: handle when WinRT APIs are unavailable #38612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrycensRanch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: handle when WinRT APIs are unavailable #38612

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ef19fa
fix: handle when WinRT APIs are unavailable
BrycensRanch Jul 12, 2026
eb9d8d5
fix: handle WinRT failures when accessing LocalFolder/TemporaryFolder
BrycensRanch Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions src/Microsoft.Data.Sqlite.Core/SqliteConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,23 +86,37 @@ static SqliteConnection()
{
// Ignore the unpackaged-app "no package identity" case; ApplicationData.Current is unavailable there.
}
catch (Exception ex) when (ex is NotImplementedException or NotSupportedException)
{
// Ignore when WinRT APIs aren't implemented or supported (e.g., running under Wine)
// ApplicationData.Current is unavailable there.
}
Comment thread
AndriySvyryd marked this conversation as resolved.

if (currentAppData != null)
{
var localFolder = appDataType?.GetRuntimeProperty("LocalFolder")?.GetValue(currentAppData);
var localFolderPath = (string?)storageFolderType?.GetRuntimeProperty("Path")?.GetValue(localFolder);
if (localFolderPath != null)
try
{
var rc = sqlite3_win32_set_directory(SQLITE_WIN32_DATA_DIRECTORY_TYPE, localFolderPath);
Debug.Assert(rc == SQLITE_OK);
var localFolder = appDataType?.GetRuntimeProperty("LocalFolder")?.GetValue(currentAppData);
var localFolderPath = (string?)storageFolderType?.GetRuntimeProperty("Path")?.GetValue(localFolder);
if (localFolderPath != null)
{
var rc = sqlite3_win32_set_directory(SQLITE_WIN32_DATA_DIRECTORY_TYPE, localFolderPath);
Debug.Assert(rc == SQLITE_OK);
}

var tempFolder = appDataType?.GetRuntimeProperty("TemporaryFolder")?.GetValue(currentAppData);
var tempFolderPath = (string?)storageFolderType?.GetRuntimeProperty("Path")?.GetValue(tempFolder);
if (tempFolderPath != null)
{
var rc = sqlite3_win32_set_directory(SQLITE_WIN32_TEMP_DIRECTORY_TYPE, tempFolderPath);
Debug.Assert(rc == SQLITE_OK);
}
}

var tempFolder = appDataType?.GetRuntimeProperty("TemporaryFolder")?.GetValue(currentAppData);
var tempFolderPath = (string?)storageFolderType?.GetRuntimeProperty("Path")?.GetValue(tempFolder);
if (tempFolderPath != null)
catch (Exception ex) when (ex is TargetInvocationException

@AndriySvyryd AndriySvyryd Jul 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it's a TargetInvocationException you still need to filter on the InnerException. Also above, for .Current

or NotImplementedException
or NotSupportedException)
{
var rc = sqlite3_win32_set_directory(SQLITE_WIN32_TEMP_DIRECTORY_TYPE, tempFolderPath);
Debug.Assert(rc == SQLITE_OK);
// Ignore failures accessing LocalFolder/TemporaryFolder when WinRT isn't fully implemented.
}
}
}
Expand Down
Loading