Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade #30948

Merged
merged 5 commits into from
Jun 12, 2023
Merged

[main] Update dependencies from dotnet/arcade #30948

merged 5 commits into from
Jun 12, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 22, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: bb100545-b369-4abf-d5f0-08d82e67fc50
  • Build: 20230609.8
  • Date Produced: June 10, 2023 2:32:23 AM UTC
  • Commit: 9994c5ed43856c35591d94ead68ef501a020eb2e
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
d0bb104 
…519.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23262.5 -> To Version 8.0.0-beta.23269.2
@dotnet-maestro dotnet-maestro bot requested a review from wtgodbe as a code owner May 22, 2023 12:02
ghost
ghost approved these changes May 22, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
eb49006 
…529.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23262.5 -> To Version 8.0.0-beta.23279.1
@bricelam
Copy link
Contributor

See dotnet/ef6#2117

@bricelam bricelam self-assigned this May 29, 2023
@bricelam
Copy link
Contributor

bricelam commented May 31, 2023 •
edited
Loading

Hmm, this is a different beast than the EF6 one. xunit.core and xunit.assert now have IsImplicitlyDefined="true" and PrivateAssets="all". Somehow, this is interfering with our specification tests even though they're defined as <IsUnitTestProject>false</IsUnitTestProject>.

With explicit references:

error NETSDK1023: A PackageReference for 'xunit.assert' was included in your project. This package is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs

Without explicit references:

error CS0246: The type or namespace name 'Xunit' could not be found (are you missing a using directive or an assembly reference?)

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
339d714 
…602.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23262.5 -> To Version 8.0.0-beta.23302.3
@bricelam bricelam removed their assignment Jun 12, 2023
@amcasey
Copy link
Member

amcasey commented Jun 12, 2023

Without having investigated at all, it seems worth noting that the aspnetcore arcade update has been blocked for a while.

@dotnet-maestro @bricelam
Update dependencies from https://github.com/dotnet/arcade build 20230…
152408e 
…609.8

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23262.5 -> To Version 8.0.0-beta.23309.8
@bricelam bricelam force-pushed the darc-main-999b923c-e6d7-4273-ab4a-3348948b2e29 branch from 5545ded to 152408e Compare June 12, 2023 20:06
@bricelam
Copy link
Contributor

The strange IsImplicitlyDefined behavior seems to be resolved. Let's see if it passes now

@bricelam bricelam self-assigned this Jun 12, 2023
@bricelam
Copy link
Contributor

Wait, maybe not. It worked three times in a row on my box then started failing again

@bricelam
Copy link
Contributor

Worked around it and filed dotnet/arcade#13798

@dotnet-maestro dotnet-maestro bot merged commit 8b986cd into main Jun 12, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-999b923c-e6d7-4273-ab4a-3348948b2e29 branch June 12, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe Awaiting requested review from wtgodbe

Assignees

@bricelam bricelam

Labels
area-infrastructure type-dependency update 🔼
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bricelam @amcasey