Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to M.E.AI 9.3.0-preview.1.25161.3 #779

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

stephentoub
Copy link
Member

No description provided.

@Copilot Copilot bot review requested due to automatic review settings March 12, 2025 03:01

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the ChatState component for compatibility with M.E.AI 9.3.0-preview.1.25161.3 by modifying the response property access and the method used to add messages.

  • Replaces response.Message.Text with response.Text.
  • Changes the add method from Messages.Add(response.Message) to Messages.AddMessages(response).
Comments suppressed due to low confidence (2)

src/WebApp/Components/Chatbot/ChatState.cs:79

  • The change from response.Message.Text to response.Text must be verified to contain the intended data.
if (!string.IsNullOrWhiteSpace(response.Text))

src/WebApp/Components/Chatbot/ChatState.cs:81

  • The method name AddMessages suggests handling multiple messages; verify that its functionality matches the intended usage with a singular response.
Messages.AddMessages(response);

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@danmoseley
Copy link
Member

Run actions/cache/restore@v4
Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set. Input key: issue-labeler/pulls/model/

@jeffhandley I think since we don't need area labels in this repo I need to switch labeler off. How do I do that? I can't figure it out

@danmoseley
Copy link
Member

without that I can't merge...

@danmoseley
Copy link
Member

oh! I"ll just remove the yml of course

@jeffhandley jeffhandley requested a review from Copilot March 14, 2025 04:32

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ChatState component to work with the new M.E.AI 9.3.0-preview.1.25161.3 release by adapting the response handling from the chat client.

  • Updated response property access from response.Message.Text to response.Text
  • Changed the message addition logic from Messages.Add(response.Message) to Messages.AddMessages(response)
Comments suppressed due to low confidence (2)

src/WebApp/Components/Chatbot/ChatState.cs:79

  • Verify that the new property 'response.Text' reliably exists and contains the complete message data as expected in all response variants.
if (!string.IsNullOrWhiteSpace(response.Text))

src/WebApp/Components/Chatbot/ChatState.cs:81

  • Ensure the AddMessages method correctly handles the structure of 'response' in the new API version and does not introduce unintended behavior.
Messages.AddMessages(response);
@jeffhandley
Copy link
Member

I disabled the workflows from the Actions page too. Sorry I didn't see this notification until now. Should be good to go though.

@jeffhandley jeffhandley merged commit ed4f50e into dotnet:main Mar 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants