[feature/10.0] Use validation source generator #8165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the new model for source generated validation from dotnet/aspnetcore#46349.
sbomer
commented
Apr 30, 2025
| context.ValidationContext.MemberName = originalMemberName; | ||
| if (hasErrors) | ||
| { | ||
| return; |
There was a problem hiding this comment.
The custom implementation of ValidateAsync for CollectionRuleOptions exists to preserve the short-circuiting behavior here for incorrect use of templates:
Without this short-circuiting, we'd get extra errors about a missing Type field in addition to the bad template reference, which is undesirable because the Type field should not be set directly if using a template.
sbomer
changed the title
Work around dotnet/aspnetcore#61379
- Re-run latest version of generators - Add comments to help point out places where manual changes were made to the generated code
Something was wrong with the previous update (maybe a caching issue). This uses the latest version of the generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new model for source generated validation from dotnet/aspnetcore#46349.
For now this checks in the generated code, with some tweaks to work around the following issues:
and the generator is disabled.
Once those issues are fixed, we can: