Record StackTraceHiddenAttribute when collecting stacks and exceptions
#7493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmittjoseph
changed the title
StackTraceHiddenAttribute when collecting stacks and exceptionsStackTraceHiddenAttribute when collecting stacks and exceptions
schmittjoseph
commented
Oct 10, 2024
| @@ -46,6 +46,7 @@ HRESULT StacksEventProvider::WriteClassData(ClassID classId, const ClassData& cl | |||
| static_cast<UINT64>(classData.GetModuleId()), | |||
| classData.GetToken(), | |||
| static_cast<UINT32>(classData.GetFlags()), | |||
| classData.GetStackTraceHidden(), | |||
There was a problem hiding this comment.
note: this relies on an implicit cast from bool to UINT32. If folks would prefer that this become an explicit static_cast<UINT32> let me know.
schmittjoseph
commented
Oct 10, 2024
| { | ||
| return Convert.ToBoolean(GetPayload<uint>(traceEvent, index)); | ||
| } | ||
|
|
||
| public static T GetPayload<T>(this TraceEvent traceEvent, int index) | ||
| { | ||
| return (T)traceEvent.PayloadValue(index); |
There was a problem hiding this comment.
note: I plan on updating this with a DEBUG check to prevent us accidentally calling it with <bool>. This will happen in a separate PR since we have an instance of using GetPayload<bool> elsewhere in dotnet-monitor that needs to get fixed first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When collecting
/stacksand/exceptionsdata, also record where theStackTraceHiddenAttributeis present. To keep PRs small and easier to review, this PR does not change the API surface, it is only focused on collecting this information and sending it to dotnet-monitor over event source. A follow up PR will expose this new information and add functional tests.Note that we use a
UINT32to transmit this information over event source instead of a boolean. This is due to a bug in event source regarding the size of bools. A separate PR will be made to fix an existing instance of this elsewhere in dotnet-monitor.Release Notes Entry