Fixed documentation for MemoryLoadBytes#10303
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
gewarren
left a comment
There was a problem hiding this comment.
Thanks for updating this. The wording wasn't exactly clear to me, so I left a suggested change.
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
gewarren
left a comment
There was a problem hiding this comment.
Oops, forgot to change the link in my previous review. We're required to leave off the learn.microsoft.com/locale part of URLs for them to resolve in air-gapped environments.
This comment was marked as outdated.
This comment was marked as outdated.
|
this still reads a bit confusing to me. for example, not sure how the reader would interpret what when a process is not running in a container or running in a container without a memory limit -
when a process is running in a container with a memory limit -
also CC-ing @janvorli for review on info about non windows side of things. |
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@janvorli, any feedback here? Explicitly highlighted the source of the memory load calculation, which prior to this change was ambiguously stated. Based on the code of |
|
Learn Build status updates of commit 832b8f5: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@gewarren, can we please merge this PR? All comments have been resolved and all the checks have passed. |
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Summary
Fixed documentation for the
MemoryLoadBytessection as it was misleading before as it's not a percentage but a quantity with units in bytes.Fixes an issue in the runtime repo: dotnet/runtime#106712
CC: @Maoni0 @cshung @mangod9 @markples