Skip to content

Added more warnings to only load trusted models#54135

Open
svick wants to merge 2 commits into
mainfrom
more-models-are-untrusted
Open

Added more warnings to only load trusted models#54135
svick wants to merge 2 commits into
mainfrom
more-models-are-untrusted

Conversation

@svick
Copy link
Copy Markdown
Member

@svick svick commented Jun 3, 2026

@svick svick requested a review from gewarren as a code owner June 3, 2026 14:55
Copilot AI review requested due to automatic review settings June 3, 2026 14:55
@svick svick requested review from a team, JakeRadMSFT and luisquintanilla as code owners June 3, 2026 14:55
@dotnetrepoman dotnetrepoman Bot added this to the June 2026 milestone Jun 3, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the ML.NET security guidance that models should only come from trusted sources by adding [!IMPORTANT] warnings to additional tutorials and how-to guides. It also attempts to fix invalid code in deep-learning-overview.md by correcting the ONNX pipeline example.

Changes:

  • Add “only load/apply trusted models” [!IMPORTANT] warnings across several ML.NET articles that demonstrate loading or applying pretrained models.
  • Update the ONNX example in deep-learning-overview.md (but the TensorFlow and ONNX snippets still need corrections to be valid, per review comments).
  • Add the same warning to model-serving guides (wording should be aligned with the established “load models” phrasing).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
docs/machine-learning/tutorials/text-classification-tf.md Adds an IMPORTANT warning before loading a pretrained TensorFlow model.
docs/machine-learning/tutorials/object-detection-onnx.md Adds an IMPORTANT warning near the ApplyOnnxModel pipeline step.
docs/machine-learning/tutorials/object-detection-custom-vision-onnx.md Adds an IMPORTANT warning before applying an ONNX model in the pipeline.
docs/machine-learning/tutorials/image-classification.md Adds an IMPORTANT warning before loading/scoring with a TensorFlow model.
docs/machine-learning/how-to-guides/serve-model-web-api-ml-net.md Adds an IMPORTANT warning before registering/loading a model for serving (needs wording consistency).
docs/machine-learning/how-to-guides/serve-model-serverless-azure-functions-ml-net.md Adds an IMPORTANT warning before registering/loading a model for serving (needs wording consistency).
docs/machine-learning/how-to-guides/retrain-model-ml-net.md Adds an IMPORTANT warning before loading a pretrained model.
docs/machine-learning/how-to-guides/machine-learning-model-predictions-ml-net.md Adds an IMPORTANT warning before loading a model for predictions.
docs/machine-learning/deep-learning-overview.md Adds an IMPORTANT warning and modifies the ONNX snippet (still needs fixes for correctness).

Comment thread docs/machine-learning/deep-learning-overview.md
Comment thread docs/machine-learning/how-to-guides/serve-model-web-api-ml-net.md
Comment thread docs/machine-learning/deep-learning-overview.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants