-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Make it more explicit that test runner selection is for .NET 10+ #50976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR clarifies that test runner selection is a .NET 10+ feature, making it explicit that earlier .NET versions (6-9) always use VSTest. The changes add a NOTE callout at the beginning of the documentation and update the VSTest description to reinforce this information.
Key changes:
- Added a NOTE callout explaining test runner selection is available starting with .NET 10 SDK
- Updated the VSTest bullet point to explicitly state it's the default and only runner for .NET 6-9
| The available command-line options, behavior, and capabilities differ depending on which test runner you use: | ||
|
|
||
| - **[dotnet test with VSTest](dotnet-test-vstest.md)** - The traditional test platform, available in .NET 6 SDK and later. Provides comprehensive test discovery, filtering, and result reporting capabilities. | ||
| - **[dotnet test with VSTest](dotnet-test-vstest.md)** - The traditional test platform, available in .NET 6 SDK and later. This is the default and only test runner for .NET 6, .NET 7, .NET 8, and .NET 9. Provides comprehensive test discovery, filtering, and result reporting capabilities. |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence structure violates the Markdown Writing Style Guidelines. The phrase "This is the default and only test runner for .NET 6, .NET 7, .NET 8, and .NET 9" is inserted mid-sentence and disrupts the flow. According to the guidelines, you should use active voice, present tense, and write like you speak using everyday words. Consider restructuring this as two separate sentences or using a more conversational flow. For example, you could write: "The traditional test platform, available in .NET 6 SDK and later. It's the default and only test runner for .NET 6, .NET 7, .NET 8, and .NET 9, and it provides comprehensive test discovery, filtering, and result reporting capabilities."
| The `dotnet test` command builds the solution and runs the tests with either VSTest or Microsoft Testing Platform (MTP). The test runner you use determines the available command-line options and behavior. | ||
|
|
||
| > [!NOTE] | ||
| > Test runner selection is available starting with .NET 10 SDK. In .NET 6, .NET 7, .NET 8, and .NET 9, tests are always executed with VSTest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easier to say "In earlier versions"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the wording "In earlier versions", or "Before .NET 10 SDK" makes sense.
| The `dotnet test` command builds the solution and runs the tests with either VSTest or Microsoft Testing Platform (MTP). The test runner you use determines the available command-line options and behavior. | ||
|
|
||
| > [!NOTE] | ||
| > Test runner selection is available starting with .NET 10 SDK. In .NET 6, .NET 7, .NET 8, and .NET 9, tests are always executed with VSTest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this is going to confuse some users who use the TestingPlatformDotnetTestSupport to run MTP on top of the VSTest target for .NET 8/9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about how to word it better, technically the runner is VSTest and that's why the command are VSTest, we just intercept the middle run to redirect to our runner (I know that's too technical and that's why I went with that wording).
Let's wait for feedback from doc team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the runner is VSTest, I would just mention that as the default test runner for versions before .NET 10 SDK. And use the same wording as the note on line 20.
| The available command-line options, behavior, and capabilities differ depending on which test runner you use: | ||
|
|
||
| - **[dotnet test with VSTest](dotnet-test-vstest.md)** - The traditional test platform, available in .NET 6 SDK and later. Provides comprehensive test discovery, filtering, and result reporting capabilities. | ||
| - **[dotnet test with VSTest](dotnet-test-vstest.md)** - The traditional test platform, available in .NET 6 SDK and later. This is the default and only test runner for .NET 6, .NET 7, .NET 8, and .NET 9. Provides comprehensive test discovery, filtering, and result reporting capabilities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here about possible confusion with TestingPlatformDotnetTestSupport.
Internal previews