Skip to content

Conversation

@Evangelink
Copy link
Member

@Evangelink Evangelink commented Jan 8, 2026


Internal previews

📄 File 🔗 Preview link
docs/core/tools/dotnet-test.md dotnet test

Copilot AI review requested due to automatic review settings January 8, 2026 08:25
@Evangelink Evangelink requested a review from a team as a code owner January 8, 2026 08:25
@dotnetrepoman dotnetrepoman bot added this to the January 2026 milestone Jan 8, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR clarifies that test runner selection is a .NET 10+ feature, making it explicit that earlier .NET versions (6-9) always use VSTest. The changes add a NOTE callout at the beginning of the documentation and update the VSTest description to reinforce this information.

Key changes:

  • Added a NOTE callout explaining test runner selection is available starting with .NET 10 SDK
  • Updated the VSTest bullet point to explicitly state it's the default and only runner for .NET 6-9

The available command-line options, behavior, and capabilities differ depending on which test runner you use:

- **[dotnet test with VSTest](dotnet-test-vstest.md)** - The traditional test platform, available in .NET 6 SDK and later. Provides comprehensive test discovery, filtering, and result reporting capabilities.
- **[dotnet test with VSTest](dotnet-test-vstest.md)** - The traditional test platform, available in .NET 6 SDK and later. This is the default and only test runner for .NET 6, .NET 7, .NET 8, and .NET 9. Provides comprehensive test discovery, filtering, and result reporting capabilities.
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence structure violates the Markdown Writing Style Guidelines. The phrase "This is the default and only test runner for .NET 6, .NET 7, .NET 8, and .NET 9" is inserted mid-sentence and disrupts the flow. According to the guidelines, you should use active voice, present tense, and write like you speak using everyday words. Consider restructuring this as two separate sentences or using a more conversational flow. For example, you could write: "The traditional test platform, available in .NET 6 SDK and later. It's the default and only test runner for .NET 6, .NET 7, .NET 8, and .NET 9, and it provides comprehensive test discovery, filtering, and result reporting capabilities."

Copilot generated this review using guidance from repository custom instructions.
The `dotnet test` command builds the solution and runs the tests with either VSTest or Microsoft Testing Platform (MTP). The test runner you use determines the available command-line options and behavior.

> [!NOTE]
> Test runner selection is available starting with .NET 10 SDK. In .NET 6, .NET 7, .NET 8, and .NET 9, tests are always executed with VSTest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier to say "In earlier versions"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the wording "In earlier versions", or "Before .NET 10 SDK" makes sense.

The `dotnet test` command builds the solution and runs the tests with either VSTest or Microsoft Testing Platform (MTP). The test runner you use determines the available command-line options and behavior.

> [!NOTE]
> Test runner selection is available starting with .NET 10 SDK. In .NET 6, .NET 7, .NET 8, and .NET 9, tests are always executed with VSTest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this is going to confuse some users who use the TestingPlatformDotnetTestSupport to run MTP on top of the VSTest target for .NET 8/9.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about how to word it better, technically the runner is VSTest and that's why the command are VSTest, we just intercept the middle run to redirect to our runner (I know that's too technical and that's why I went with that wording).

Let's wait for feedback from doc team.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the runner is VSTest, I would just mention that as the default test runner for versions before .NET 10 SDK. And use the same wording as the note on line 20.

The available command-line options, behavior, and capabilities differ depending on which test runner you use:

- **[dotnet test with VSTest](dotnet-test-vstest.md)** - The traditional test platform, available in .NET 6 SDK and later. Provides comprehensive test discovery, filtering, and result reporting capabilities.
- **[dotnet test with VSTest](dotnet-test-vstest.md)** - The traditional test platform, available in .NET 6 SDK and later. This is the default and only test runner for .NET 6, .NET 7, .NET 8, and .NET 9. Provides comprehensive test discovery, filtering, and result reporting capabilities.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here about possible confusion with TestingPlatformDotnetTestSupport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants