Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make some on instance classes static #10346

Closed
wants to merge 3 commits into from
Closed

make some on instance classes static #10346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6af053b
make some on instance classes static
SimonCropp Nov 3, 2024
e20e199
Merge branch 'main' into make-some-on-instance-classes-static
SimonCropp Nov 5, 2024
e206979
Merge branch 'main' into make-some-on-instance-classes-static
yufeih Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Docfx.Build.Common/Reference/OverwriteDocumentReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

namespace Docfx.Build.Common;

public class OverwriteDocumentReader
public static class OverwriteDocumentReader
{
public static FileModel Read(FileAndType file)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Docfx.Dotnet/Filters/RoslynFilterData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Docfx.Dotnet;

internal class RoslynFilterData
internal static class RoslynFilterData
{
public static SymbolFilterData GetSymbolFilterData(ISymbol symbol)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Docfx.Dotnet/ManagedReference/Visitors/SpecIdHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

namespace Docfx.Dotnet;

internal sealed class SpecIdHelper
internal static class SpecIdHelper
{
private static readonly Regex TypeParameterRegex = new(@"\B(?<!`)`\d+", RegexOptions.Compiled);
private static readonly Regex MethodParameterRegex = new(@"\B``\d+", RegexOptions.Compiled);
Expand Down Expand Up @@ -82,7 +82,7 @@ private static string SpecMethodGenericParameter(IReadOnlyList<string> names, st
}

/// <summary>
/// spec extension method's receiver type.
/// spec extension method's receiver type.
/// for below overload: M(this A), M(this A, A), AddReference applies to the first method and AddSpecReference applies to the second method might get same id without prepending receiver type.
/// </summary>
/// <param name="symbol">symbol</param>
Expand Down
Loading