Simplify the JsonTempDataSerializer#65483
Draft
dariatiurina wants to merge 2 commits intodotnet:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the JsonTempDataSerializer
Summary
Simplifies the
JsonTempDataSerializerby storing type information alongside each value, eliminating the need for heuristic type inference during deserialization. This removes the source-generatedJsonTempDataSerializerContextand replaces hand-written per-type deserialization logic with a directJsonSerializer.Deserializecall using the stored type.Changes
IDictionary<string, object?>toIDictionary<string, (object? Value, Type? Type)>so values carry their original type through the pipeline.{ "type": "<type-fullname>", "value": <json> }instead of a raw JSON value.JsonTempDataSerializerContext(source-generated context with ~30[JsonSerializable]attributes) — no longer needed since the type is stored explicitly.DeserializeElement,DeserializeString,DeserializeArray,DeserializeObject,GetArrayTypeInfo,GetStringType) that inferred types fromJsonValueKind.CanSerializeto use a staticHashSet<Type>of supported types.ICollection<T>types (e.g.,List<T>,HashSet<T>) toT[]during serialization.ITempDataProvider,ITempDataSerializer,TempDataService,CookieTempDataProvider,SessionStorageTempDataProvider, andTempDatato use the new tuple-based dictionary.Testing
RoundTriptheory covering int, bool, string, Guid, DateTime, arrays, and dictionaries.List<T>→ array normalization, andHashSet<T>→ array normalization.ValidTypescoverage with additional types (string[], bool[], DateTime[], Dictionary<string,T> variants, enums, List, HashSet).Fixes #65231