Skip to content

Handle ObjectDisposedException in SignalR OnDisconnectedAsync during shutdown #65457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adityamandaleeka wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Handle ObjectDisposedException in SignalR OnDisconnectedAsync during shutdown #65457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
520e95a
Fix flaky LongPollingWorks test by filtering expected ObjectDisposedE…
adityamandaleeka Feb 18, 2026
2ddd38c
Handle ObjectDisposedException in SignalR OnDisconnectedAsync during …
adityamandaleeka Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions src/SignalR/server/Core/src/Internal/DefaultHubDispatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,36 @@ public override async Task OnConnectedAsync(HubConnectionContext connection)

public override async Task OnDisconnectedAsync(HubConnectionContext connection, Exception? exception)
{
await using var scope = _serviceScopeFactory.CreateAsyncScope();
AsyncServiceScope scope;
try
{
scope = _serviceScopeFactory.CreateAsyncScope();
}
catch (ObjectDisposedException)
{
// The service provider was disposed during shutdown. We can't resolve the hub
// or run OnDisconnectedAsync, so just no-op.
Log.ServiceProviderDisposedWhileDisconnecting(_logger);
return;
}

await using var _ = scope;

IHubActivator<THub> hubActivator;
THub hub;
try
{
hubActivator = scope.ServiceProvider.GetRequiredService<IHubActivator<THub>>();
hub = hubActivator.Create();
}
catch (ObjectDisposedException)
{
// The service provider can be disposed between CreateAsyncScope() and service
// resolution during shutdown.
Log.ServiceProviderDisposedWhileDisconnecting(_logger);
return;
}

var hubActivator = scope.ServiceProvider.GetRequiredService<IHubActivator<THub>>();
var hub = hubActivator.Create();
Activity? activity = null;
try
{
Expand Down
3 changes: 3 additions & 0 deletions src/SignalR/server/Core/src/Internal/DefaultHubDispatcherLog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,7 @@ public static void ClosingStreamWithBindingError(ILogger logger, CompletionMessa

[LoggerMessage(28, LogLevel.Trace, "Received SequenceMessage with Sequence ID '{SequenceId}'.", EventName = "ReceivedSequenceMessage")]
public static partial void ReceivedSequenceMessage(ILogger logger, long sequenceId);

[LoggerMessage(29, LogLevel.Debug, "The service provider was disposed while dispatching 'OnDisconnectedAsync'. Unable to run Hub.OnDisconnectedAsync.", EventName = "ServiceProviderDisposedWhileDisconnecting")]
public static partial void ServiceProviderDisposedWhileDisconnecting(ILogger logger);
}
Loading