-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Use dnceng AzDO feed for maven #64962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fixes CFSClean errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR consolidates Maven repository configuration for the SignalR Java client by migrating from public repositories (Maven Central and Gradle Plugin Portal) to Microsoft's internal dnceng Azure DevOps feed. The change centralizes repository management in settings.gradle using modern Gradle best practices and is intended to resolve CFSClean (Component Governance) errors.
Key Changes:
- Centralized all repository declarations in
settings.gradleusingpluginManagementanddependencyResolutionManagement - Removed repository declarations from
build.gradlebuildscript and allprojects blocks - Configured
FAIL_ON_PROJECT_REPOSmode to enforce centralized repository management
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SignalR/clients/java/signalr/settings.gradle | Adds pluginManagement and dependencyResolutionManagement blocks with dnceng AzDO feed configuration, enforces centralized repository management |
| src/SignalR/clients/java/signalr/build.gradle | Removes buildscript repositories block and allprojects repositories block, relying on settings.gradle configuration |
Comments suppressed due to low confidence (1)
src/SignalR/clients/java/signalr/build.gradle:5
- The buildscript block declares a classpath dependency on spotless-plugin-gradle, but no repositories are configured for resolving this dependency. Buildscript dependencies are not resolved from the pluginManagement repositories in settings.gradle. You need to either add a repositories block within the buildscript block or convert this to use the plugins DSL instead. Consider replacing the buildscript approach with the plugins DSL by adding the plugin ID to the plugins block.
buildscript {
dependencies {
classpath "com.diffplug.spotless:spotless-plugin-gradle:6.6.1"
}
}
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
Components failure unrelated |
* Use dnceng AzDO feed for maven This fixes CFSClean errors. * Upgrade spotless-plugin-gradle to fix error with latest gradle --------- Co-authored-by: William Godbe <[email protected]>
* Use dnceng AzDO feed for maven This fixes CFSClean errors. * Upgrade spotless-plugin-gradle to fix error with latest gradle --------- Co-authored-by: William Godbe <[email protected]>
* Use dnceng AzDO feed for maven This fixes CFSClean errors. * Upgrade spotless-plugin-gradle to fix error with latest gradle --------- Co-authored-by: William Godbe <[email protected]>
* Update gradle * update jdk * not specific ex * fixup * fixup * Use dnceng AzDO feed for maven (#64962) * Use dnceng AzDO feed for maven This fixes CFSClean errors. * Upgrade spotless-plugin-gradle to fix error with latest gradle --------- Co-authored-by: William Godbe <[email protected]> --------- Co-authored-by: Brennan Conroy <[email protected]> Co-authored-by: Alexander Köplinger <[email protected]> Co-authored-by: William Godbe <[email protected]>
* Update gradle * update jdk * not specific ex * fixup * fixup * Use dnceng AzDO feed for maven (#64962) * Use dnceng AzDO feed for maven This fixes CFSClean errors. * Upgrade spotless-plugin-gradle to fix error with latest gradle --------- Co-authored-by: William Godbe <[email protected]> * Bump gson --------- Co-authored-by: Brennan Conroy <[email protected]> Co-authored-by: Alexander Köplinger <[email protected]> Co-authored-by: William Godbe <[email protected]>
* Update gradle * update jdk * not specific ex * fixup * fixup * Use dnceng AzDO feed for maven (#64962) * Use dnceng AzDO feed for maven This fixes CFSClean errors. * Upgrade spotless-plugin-gradle to fix error with latest gradle --------- Co-authored-by: William Godbe <[email protected]> * Bump gson * Update okhttp to 4.12 (#55434) --------- Co-authored-by: Brennan Conroy <[email protected]> Co-authored-by: Alexander Köplinger <[email protected]> Co-authored-by: William Godbe <[email protected]> Co-authored-by: Haidar <[email protected]>
This fixes CFSClean errors.