Skip to content

Conversation

@akoeplinger
Copy link
Member

This fixes CFSClean errors.

This fixes CFSClean errors.
@akoeplinger akoeplinger requested a review from wtgodbe January 7, 2026 11:18
Copilot AI review requested due to automatic review settings January 7, 2026 11:18
@github-actions github-actions bot added the area-signalr Includes: SignalR clients and servers label Jan 7, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates Maven repository configuration for the SignalR Java client by migrating from public repositories (Maven Central and Gradle Plugin Portal) to Microsoft's internal dnceng Azure DevOps feed. The change centralizes repository management in settings.gradle using modern Gradle best practices and is intended to resolve CFSClean (Component Governance) errors.

Key Changes:

  • Centralized all repository declarations in settings.gradle using pluginManagement and dependencyResolutionManagement
  • Removed repository declarations from build.gradle buildscript and allprojects blocks
  • Configured FAIL_ON_PROJECT_REPOS mode to enforce centralized repository management

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/SignalR/clients/java/signalr/settings.gradle Adds pluginManagement and dependencyResolutionManagement blocks with dnceng AzDO feed configuration, enforces centralized repository management
src/SignalR/clients/java/signalr/build.gradle Removes buildscript repositories block and allprojects repositories block, relying on settings.gradle configuration
Comments suppressed due to low confidence (1)

src/SignalR/clients/java/signalr/build.gradle:5

  • The buildscript block declares a classpath dependency on spotless-plugin-gradle, but no repositories are configured for resolving this dependency. Buildscript dependencies are not resolved from the pluginManagement repositories in settings.gradle. You need to either add a repositories block within the buildscript block or convert this to use the plugins DSL instead. Consider replacing the buildscript approach with the plugins DSL by adding the plugin ID to the plugins block.
buildscript {
  dependencies {
    classpath "com.diffplug.spotless:spotless-plugin-gradle:6.6.1"
  }
}

@akoeplinger akoeplinger mentioned this pull request Jan 8, 2026
@wtgodbe
Copy link
Member

wtgodbe commented Jan 8, 2026

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@wtgodbe
Copy link
Member

wtgodbe commented Jan 8, 2026

Components failure unrelated

@wtgodbe wtgodbe merged commit cc57aae into main Jan 8, 2026
23 of 25 checks passed
@wtgodbe wtgodbe deleted the maven-feed branch January 8, 2026 21:25
@dotnet-policy-service dotnet-policy-service bot added this to the 11.0-preview1 milestone Jan 8, 2026
wtgodbe added a commit that referenced this pull request Jan 8, 2026
* Use dnceng AzDO feed for maven

This fixes CFSClean errors.

* Upgrade spotless-plugin-gradle to fix error with latest gradle

---------

Co-authored-by: William Godbe <[email protected]>
wtgodbe added a commit that referenced this pull request Jan 8, 2026
* Use dnceng AzDO feed for maven

This fixes CFSClean errors.

* Upgrade spotless-plugin-gradle to fix error with latest gradle

---------

Co-authored-by: William Godbe <[email protected]>
wtgodbe added a commit that referenced this pull request Jan 8, 2026
* Use dnceng AzDO feed for maven

This fixes CFSClean errors.

* Upgrade spotless-plugin-gradle to fix error with latest gradle

---------

Co-authored-by: William Godbe <[email protected]>
wtgodbe added a commit that referenced this pull request Jan 8, 2026
* Update gradle

* update jdk

* not specific ex

* fixup

* fixup

* Use dnceng AzDO feed for maven (#64962)

* Use dnceng AzDO feed for maven

This fixes CFSClean errors.

* Upgrade spotless-plugin-gradle to fix error with latest gradle

---------

Co-authored-by: William Godbe <[email protected]>

---------

Co-authored-by: Brennan Conroy <[email protected]>
Co-authored-by: Alexander Köplinger <[email protected]>
Co-authored-by: William Godbe <[email protected]>
wtgodbe added a commit that referenced this pull request Jan 9, 2026
* Update gradle

* update jdk

* not specific ex

* fixup

* fixup

* Use dnceng AzDO feed for maven (#64962)

* Use dnceng AzDO feed for maven

This fixes CFSClean errors.

* Upgrade spotless-plugin-gradle to fix error with latest gradle

---------

Co-authored-by: William Godbe <[email protected]>

* Bump gson

---------

Co-authored-by: Brennan Conroy <[email protected]>
Co-authored-by: Alexander Köplinger <[email protected]>
Co-authored-by: William Godbe <[email protected]>
wtgodbe added a commit that referenced this pull request Jan 9, 2026
* Update gradle

* update jdk

* not specific ex

* fixup

* fixup

* Use dnceng AzDO feed for maven (#64962)

* Use dnceng AzDO feed for maven

This fixes CFSClean errors.

* Upgrade spotless-plugin-gradle to fix error with latest gradle

---------

Co-authored-by: William Godbe <[email protected]>

* Bump gson

* Update okhttp to 4.12 (#55434)

---------

Co-authored-by: Brennan Conroy <[email protected]>
Co-authored-by: Alexander Köplinger <[email protected]>
Co-authored-by: William Godbe <[email protected]>
Co-authored-by: Haidar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-signalr Includes: SignalR clients and servers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants