Identity metrics clean up #62671
Open
Identity metrics clean up #62671
+45
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default metric value for unknown cases from _UNKNOWN to _OTHER across identity-related switch expressions, aligning with the correct metric nomenclature.
- Replaces
_UNKNOWNwith_OTHERinGetTokenPurpose - Replaces
_UNKNOWNwith_OTHERinGetPasswordResult - Replaces
_UNKNOWNwith_OTHERinGetUpdateType
Comments suppressed due to low confidence (3)
src/Identity/Extensions.Core/src/UserManagerMetrics.cs:172
- Add a unit test to verify that GetTokenPurpose returns "_OTHER" for unrecognized purposes.
_ => "_OTHER"
src/Identity/Extensions.Core/src/UserManagerMetrics.cs:207
- Add a unit test to verify that GetPasswordResult returns "_OTHER" for cases falling through the specified patterns.
_ => "_OTHER"
src/Identity/Extensions.Core/src/UserManagerMetrics.cs:247
- Add a unit test to verify that GetUpdateType returns "_OTHER" for unhandled UserUpdateType values.
_ => "_OTHER"
|
Is _UNKNOWN correct here |
JamesNK
changed the title
lmolkova
approved these changes
Jul 15, 2025
| _checkPasswordCounter = _meter.CreateCounter<long>(CheckPasswordCounterName, "count", "The number of check password attempts. Only checks whether the password is valid and not whether the user account is in a state that can log in."); | ||
| _verifyTokenCounter = _meter.CreateCounter<long>(VerifyTokenCounterName, "count", "The number of token verification attempts."); | ||
| _generateTokenCounter = _meter.CreateCounter<long>(GenerateTokenCounterName, "count", "The number of token generation attempts."); | ||
| _createCounter = _meter.CreateCounter<long>(CreateCounterName, "{create}", "The number of users created."); |
There was a problem hiding this comment.
it counts users, so should it be
Suggested change
| _createCounter = _meter.CreateCounter<long>(CreateCounterName, "{create}", "The number of users created."); | |
| _createCounter = _meter.CreateCounter<long>(CreateCounterName, "{user}", "The number of users created."); |
?
There was a problem hiding this comment.
You'd like create, update and delete metrics to have a unit of {user}?
| } | ||
| } | ||
|
|
||
| private static void AddExceptionTags(ref TagList tags, Exception? exception) | ||
| private static void AddExceptionTags(ref TagList tags, Exception? exception, IdentityResult? result = null) |
There was a problem hiding this comment.
nit
Suggested change
| private static void AddExceptionTags(ref TagList tags, Exception? exception, IdentityResult? result = null) | |
| private static void AddErrrorTags(ref TagList tags, Exception? exception, IdentityResult? result = null) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_OTHERis the correct value to use when give a value outside of the known set.