-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[release/10.0-preview4] Backport identity template fix. #61795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/10.0-preview4
Are you sure you want to change the base?
[release/10.0-preview4] Backport identity template fix. #61795
Conversation
@@ -60,6 +64,11 @@ | |||
|
|||
private async Task OnValidSubmitAsync() | |||
{ | |||
if (user is null) | |||
{ | |||
throw new InvalidOperationException("User is not loaded; failed to set password."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make this message more "human-friendly".
Alternatively, within OnIntializedAsync
we can check RenderInfo.IsInteractive and potentially throw an exception there, or display an alternative UI with an error message (or redirect to the error page).
@MackinnonBuck since this affects the Identity UX it will be good if we can figure this out together.
Ultimately with the exception going away we need to provide an alternative, it might be throwing, redirecting to the error page or showing a message in this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MackinnonBuck just FYI, we might merge this to unblock things and do a follow up to cleanup things when we've had a chance to talk together through this.
Hi @@ilonatommy. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
Partial backport of #61633 to release/10.0-preview4
Description
-auth Individual
) were expectingNavigateTo
to throw. We should remove this expectation for the new way of navigation.Fixes #3609
Customer Impact
Customer code based on the template won't be throwing after each redirection because the exceptions located after each redirect action got removed. If the customer misuses the identity manager class, they won't notice if they call
RedirectTo
from non-static code.Regression?
Risk
This is a change to templates only.
Verification
Packaging changes reviewed?