Split out collectors and handle process crash before backchannel connection. #9113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
davidfowl
reviewed
May 6, 2025
davidfowl
reviewed
May 6, 2025
davidfowl
approved these changes
May 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9051
This PR does two things. First it introduces error handling so that if the apphost process crashes before a backchannel is established that we detect that and display log outputs instead of just the generic error message. The other thing it does is that in the case of the
aspire runandaspire publishcommand its splits out the build and run output collectors (build inspect and publish in the case of the publish command) so that we are only showing the most relevant logs.aspire-publish-pre-backchannel-crash.mp4