Skip to content

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented May 4, 2025

Following on from the changes to split out hidden resource state into an IsHidden field, removing the hacks that I had in AppHostRpcTarget.

Also fixes: #9098

@mitchdenny mitchdenny self-assigned this May 4, 2025
@mitchdenny mitchdenny requested a review from davidfowl May 4, 2025 14:49
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label May 4, 2025
@mitchdenny mitchdenny requested a review from adamint May 4, 2025 14:49
@mitchdenny mitchdenny added area-cli and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels May 4, 2025 — with GitHub Codespaces
@mitchdenny mitchdenny added this to the 9.3 milestone May 4, 2025
@mitchdenny mitchdenny changed the title Use north WaitForResourceHealthyAsync in AppHostRpcTarget. Use normal WaitForResourceHealthyAsync in AppHostRpcTarget. May 4, 2025
@mitchdenny mitchdenny closed this May 5, 2025
@mitchdenny mitchdenny reopened this May 5, 2025
@davidfowl
Copy link
Member

Overlaps with #9092

@mitchdenny
Copy link
Member Author

@adamint I'll yield for your merge :)

Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the health check change

@davidfowl davidfowl merged commit 7ffd0ce into main May 5, 2025
169 of 170 checks passed
@davidfowl davidfowl deleted the mitchdenny/remove-dashboard-hidden-hacks branch May 5, 2025 20:14
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs from aspire_dashboard_check
2 participants