Refactor Azure Container Apps processing #9075
Merged
+284
−278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-integrations
eerhardt
reviewed
May 2, 2025
eerhardt
reviewed
May 2, 2025
|
|
||
| if (secretType == SecretType.KeyVault) | ||
| { | ||
| // TODO: this should be able to use ToUri(), but it hit an issue |
There was a problem hiding this comment.
Did we ever log an issue for this?
- Split the 2 phases and state more clearly. The first pass is handled directly in before start and resolved environment variables, arguments, volumes, endpoints. - The second pass is during bicep writing where that data is processed and translated into the underlying bicep primitives.
davidfowl
force-pushed
the
davidfowl/clean-up-container-app
branch
from
48a97a0 to
9320990
Compare
mitchdenny
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Checklist