Wait for dashboard to be healthy before returning URL via RPC (revert-revert) #9044
+61
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… via RPC…" This reverts commit 935f06b.
github-actions
bot
added
the
area-app-model
mitchdenny
changed the title
davidfowl
approved these changes
May 2, 2025
mitchdenny
deleted the
revert-9038-revert-9027-mitchdenny/devcontainer-dashboard-portforwarding-bug
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9038
This PR reverts an earlier revert (with some modifications). Previous we used WaitForResourceHealthyAsync(...) which worked in the repo but failed in the nightly builds. This is because in the repo we show the dashboard resource in the resources list (its not hidden) but in the release packages the dashboard has a hidden state.
This change introduces a temporary work around n the
ResourceHealthCheckServicewhich special cases the dashboard resource so that health checks will be run for the dashboard.Then in the
AppHostRpcTargetwe special case aWaitForResourceAsynccall so that we wait for all the dashboard resource health reports to be healthy.This change will go in before #9063 - but once that change is fully tested and merged we can refine this code to be less hacky. I want to get this in before though because I think #9063 may take a little bit to thoroughly test.