-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pomelo MySQL to v9 Preview #6948
base: main
Are you sure you want to change the base?
Conversation
This removes use of the legacy global 'MySqlConnectorLogManager.Provider' and uses Microsoft.Extensions.Logging (via MySqlDataSource). Needed to add VersionOverride for multiple packages due to Microsoft.EntityFrameworkCore.Relational v9.0.0.
I see two problems so far, but someone should confirm. This version targets net8.0 only and it lifts EF core 9.0 only. Meaning an application targeting net8.0 will take a dependency on STS packages. See what npgsql did between 9.0.0 and 9.0.1 to fix that by introducing two TFMs in the package to point to efcore 8.0 and efcore 9.0 based on the targets. |
I noted this in the PR checklist, but should have made this a "Draft" PR to be explicit: I don't expect this to be merged until Pomelo goes RTM.
I'm not following yet (perhaps because I'm less familiar with EFCore than ADO.NET). It looks like Npgsql.EntityFrameworkCore.PostgreSQL 9.0.x depends only on EFCore 9; it doesn't have multiple TFMs? https://www.nuget.org/packages/Npgsql.EntityFrameworkCore.PostgreSQL/9.0.1#dependencies-body-tab |
Right. Check this PR for instance after such a change in the library was done. |
another option is to have a version for each TFM, and keep all the things net8.0 and net9.0 separate. This is what is bound to happen with npgsql for now since there is an issue when using npgsql:9.0 targeting EF 8. |
Description
This removes use of the legacy global 'MySqlConnectorLogManager.Provider' and uses Microsoft.Extensions.Logging (via MySqlDataSource).
Needed to add VersionOverride for multiple packages due to Microsoft.EntityFrameworkCore.Relational v9.0.0.
Needs MySqlConnector.* 2.4.0 and Pomelo.EntityFrameworkCore.MySql 9.0.0-preview.2.efcore.9.0.0 to be added to approved packages list.
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):Microsoft Reviewers: Open in CodeFlow