Move the manifest support in Arcade into its own package and remove VersionTools #15661
+349
−6,976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the VMR and other users to reference this package, rather than the feed tasks. The feed tasks are not set up for nice PackageRef consumption. In addition, eliminate VersionTools, except the CLI tool, which mainly just has a command that removes version numbers from nuget packages. VersionTools is no longer in use except in the docker repo, for opening GitHub PRs. Matt Thalman indicated it would be good to remove such a dependency at some point in the future. The current dep is on net9. At the very least, we would copy the net9 code into the repo.
mmitche
changed the title
ViktorHofer
reviewed
Mar 20, 2025
src/Microsoft.DotNet.Build.Manifest/Microsoft.DotNet.Build.Manifest.csproj
Show resolved
Hide resolved
mmitche
added a commit
to mmitche/sdk
that referenced
this pull request
Mar 25, 2025
Depends on dotnet/arcade#15661 Removes the custom manifest handling in MergeAssetManifests, moving it to use the new manifest package produced by arcade. This reduces code duplication and means more complete manifests out of the each vertical. Add tests for the merging, based on manifests coming out of the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the VMR and other users to reference this package, rather than the feed tasks. The feed tasks are not set up for nice PackageRef consumption. In addition, eliminate VersionTools, except the CLI tool, which mainly just has a command that removes version numbers from nuget packages. VersionTools is no longer in use except in the docker repo, for opening GitHub PRs. Matt Thalman indicated it would be good to remove such a dependency at some point in the future. The current dep is on net9. At the very least, we would copy the net9 code into the repo.
To double check: