Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PushToBuildStorage to only push the asset manifest #15639

Merged
merged 2 commits into from
Mar 15, 2025

Conversation

jkoritzinsky
Copy link
Member

This allows us to use GenerateBuildManifest to split the "join verticals" job in the VMR and have a "build the merged manifest" job and a "download/upload artifacts" job.

Alternatively, we can remove GenerateBuildManifest (it has no users today) and add a "don't publish artifacts" option to PushToBuildStorage so it just produces the build model.

This allows us to use GenerateBuildManifest to split the "join verticals" job in the VMR and have a "build the merged manifest" job and a "download/upload artifacts" job.

Alternatively, we can remove GenerateBuildManifest (it has no users today) and add a "don't publish artifacts" option to PushToBuildStorage so it just produces the build model.
@ViktorHofer
Copy link
Member

This allows us to use GenerateBuildManifest to split the "join verticals" job in the VMR and have a "build the merged manifest" job and a "download/upload artifacts" job.

Do we have an issue that tracks this work? Trying to understand the end goal here.

Alternatively, we can remove GenerateBuildManifest (it has no users today) and add a "don't publish artifacts" option to PushToBuildStorage so it just produces the build model.

This sounds more reasonable to me.

@jkoritzinsky
Copy link
Member Author

This all falls into #15317 as this would allow us to remove our manifest parsing logic in join-verticals.

@jkoritzinsky jkoritzinsky changed the title Add artifact visibility support to GenerateBuildManifest Allow PushToBuildStorage to only push the asset manifest Mar 14, 2025
@jkoritzinsky
Copy link
Member Author

@ViktorHofer I've updated this to instead be an option on PushToBuildStorage and deleted GenerateBuildManifest.

@mmitche
Copy link
Member

mmitche commented Mar 14, 2025

Let's be sure there is no reference anywhere to GBM, but I like this option better tbh. The next step here, would be that you would supply the artifact names where assets are pushed on the input manifests, and then this task would verify everything is in the right place. This would be the eventual state of all .NET builds.

@jkoritzinsky
Copy link
Member Author

I've already validated that there's definitely no reference. The only reason we have it still is the commit that removed it and the commit that refactored it merged in simultaneously so it was restored right after it was deleted.

@jkoritzinsky jkoritzinsky merged commit 1912d9f into dotnet:main Mar 15, 2025
11 checks passed
@jkoritzinsky jkoritzinsky deleted the asset-visibility-manifest branch March 15, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants