Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SignCheck] Output results to an xml file #15591

Merged
merged 2 commits into from
Mar 5, 2025
Merged

[SignCheck] Output results to an xml file #15591

merged 2 commits into from
Mar 5, 2025

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Mar 4, 2025 •
edited
Loading

The logged signing results are difficult to parse because they only show files that are containers or are unexpectedly unsigned. This new logic adds functionality to output all results to an xml file for easier viewing.

Example output:

<SignCheckResults>
  <File Name="FakeSignedContents.nupkg" ResultType="Unsigned">
    <File Name="FakeSignedContents.nupkg/.signature.p7s" ResultType="Skipped" />
    <File Name="FakeSignedContents.nupkg/tools/SignedScript.ps1" ResultType="Skipped" />
  </File>
  <File Name="MsiSetup.msi.wixpack.zip" ResultType="Skipped">
    <File Name="MsiSetup.msi.wixpack.zip/ABCDEFG/MsiApplication.exe" ResultType="Skipped" />
    <File Name="MsiSetup.msi.wixpack.zip/create.cmd" ResultType="Skipped" />
    <File Name="MsiSetup.msi.wixpack.zip/Product.wixobj" ResultType="Skipped" />
  </File>
  <File Name="WithApp.pkg" ResultType="Skipped" />
  <File Name="SameFiles1.zip" ResultType="Skipped">
    <File Name="SameFiles1.zip/Simple1.exe" ResultType="Skipped" />
    <File Name="SameFiles1.zip/Simple2.exe" ResultType="Skipped" />
  </File>
</SignCheckResults>

@ellahathaway ellahathaway requested a review from mmitche March 4, 2025 23:55
mmitche
mmitche previously approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@mmitche mmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Winner winner chicken dinner. Approved with minor comment.

@ellahathaway ellahathaway requested a review from mmitche March 5, 2025 21:35
@ellahathaway ellahathaway merged commit b15b738 into dotnet:main Mar 5, 2025
11 checks passed
@ellahathaway ellahathaway deleted the signcheck-logging branch March 5, 2025 23:39
YuliiaKovalova pushed a commit that referenced this pull request Mar 20, 2025
@ellahathaway @YuliiaKovalova
[SignCheck] Output results to an xml file (#15591)
fd0248a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitche mmitche mmitche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellahathaway @mmitche