Add option in Arcade to preserve RepoOrigin and insert it into the publish-to-disk path #15572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n publishing to disk.
…reserve a passed-in repo origin
| { | ||
| Directory.CreateDirectory(NonShippingPackagesLocalStorageDir); | ||
| CopyFileAsHardLinkIfPossible(path, Path.Combine(NonShippingPackagesLocalStorageDir, filename), true); | ||
| packageDestinationPath = Path.Combine(packageDestinationPath, artifactModel.RepoOrigin); |
There was a problem hiding this comment.
Appending artifactModel.RepoOrigin directly to file paths could lead to unintended directory traversal if it contains path separator characters. Consider sanitizing or validating the RepoOrigin value before using it in Path.Combine.
Suggested change
| packageDestinationPath = Path.Combine(packageDestinationPath, artifactModel.RepoOrigin); | |
| packageDestinationPath = Path.Combine(packageDestinationPath, SanitizeRepoOrigin(artifactModel.RepoOrigin)); |
mmitche
reviewed
Mar 3, 2025
mmitche
reviewed
Mar 3, 2025
mmitche
approved these changes
Mar 5, 2025
YuliiaKovalova
pushed a commit
that referenced
this pull request
Mar 20, 2025
…blish-to-disk path (#15572)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow publishing to publish packages to a repo-specific subfolder when publishing to disk.
This (in combination with changes in the VMR orchestrator) will allow us to publish a given VMR vertical with the built-in Arcade publishing logic instead of the custom task we have today.
Contributes to dotnet/sdk#47076
To double check: