-
Notifications
You must be signed in to change notification settings - Fork 317
[6.0] Dependency Cleanup #3840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/6.0
Are you sure you want to change the base?
[6.0] Dependency Cleanup #3840
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,14 @@ | |
| <ItemGroup> | ||
| <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" /> | ||
| <PackageReference Include="Microsoft.SqlServer.SqlManagementObjects" Version="$(MicrosoftSqlServerSqlManagementObjectsVersion)" /> | ||
| <!-- | ||
| Explicitly reference the latest published MDS 5.1.x version here to avoid | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This took a long time to figure out. |
||
| an older version (5.1.5) being included transitively by | ||
| SqlManagementObjects. The older version brings in a vulnerable version of | ||
| System.Formats.Asn1 | ||
| --> | ||
| <PackageReference Include="Microsoft.Data.SqlClient" Version="5.1.8" /> | ||
|
|
||
| <ProjectReference Include="../Microsoft.Data.SqlClient.TestUtilities/Microsoft.Data.SqlClient.TestUtilities.csproj" /> | ||
| </ItemGroup> | ||
| </Project> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,54 +24,48 @@ | |
| <!-- NetFx project dependencies --> | ||
| <PropertyGroup> | ||
| <MicrosoftDataSqlClientSniVersion>6.0.2</MicrosoftDataSqlClientSniVersion> | ||
| <SystemBuffersVersion>4.5.1</SystemBuffersVersion> | ||
| <SystemBuffersVersion>4.6.1</SystemBuffersVersion> | ||
| <SystemMemoryVersion>4.5.5</SystemMemoryVersion> | ||
| <SystemTextEncodingsWebVersion>8.0.0</SystemTextEncodingsWebVersion> | ||
| <SystemTextJsonVersion>8.0.5</SystemTextJsonVersion> | ||
| <SystemTextJsonVersion>8.0.6</SystemTextJsonVersion> | ||
| </PropertyGroup> | ||
| <!-- NetFx and NetCore project dependencies --> | ||
| <PropertyGroup> | ||
| <AzureIdentityVersion>1.14.2</AzureIdentityVersion> | ||
| <MicrosoftBclCryptographyVersion>8.0.0</MicrosoftBclCryptographyVersion> | ||
| <MicrosoftExtensionsCachingMemoryVersion>8.0.1</MicrosoftExtensionsCachingMemoryVersion> | ||
| <MicrosoftIdentityModelJsonWebTokensVersion>7.5.0</MicrosoftIdentityModelJsonWebTokensVersion> | ||
| <MicrosoftIdentityModelProtocolsOpenIdConnectVersion>7.5.0</MicrosoftIdentityModelProtocolsOpenIdConnectVersion> | ||
| <MicrosoftIdentityModelJsonWebTokensVersion>7.7.1</MicrosoftIdentityModelJsonWebTokensVersion> | ||
| <MicrosoftIdentityModelProtocolsOpenIdConnectVersion>7.7.1</MicrosoftIdentityModelProtocolsOpenIdConnectVersion> | ||
| <SystemRuntimeInteropServicesRuntimeInformationVersion>4.3.0</SystemRuntimeInteropServicesRuntimeInformationVersion> | ||
| <SystemSecurityCryptographyPkcsVersion>8.0.1</SystemSecurityCryptographyPkcsVersion> | ||
| </PropertyGroup> | ||
| <!-- NetCore project dependencies --> | ||
| <PropertyGroup> | ||
| <MicrosoftDataSqlClientSNIRuntimeVersion>6.0.2</MicrosoftDataSqlClientSNIRuntimeVersion> | ||
| <SystemConfigurationConfigurationManagerVersion>8.0.1</SystemConfigurationConfigurationManagerVersion> | ||
| <MicrosoftSqlServerServerVersion>1.0.0</MicrosoftSqlServerServerVersion> | ||
| <SystemConfigurationConfigurationManagerVersion>8.0.1</SystemConfigurationConfigurationManagerVersion> | ||
| <SystemSecurityCryptographyPkcsVersion>8.0.1</SystemSecurityCryptographyPkcsVersion> | ||
| </PropertyGroup> | ||
| <!-- AKV Provider project dependencies --> | ||
| <PropertyGroup> | ||
| <AzureCoreVersion>[1.47.1,2.0.0)</AzureCoreVersion> | ||
| <AzureSecurityKeyVaultKeysVersion>[4.7.0,5.0.0)</AzureSecurityKeyVaultKeysVersion> | ||
| <AzureCoreVersion>1.47.1</AzureCoreVersion> | ||
| <AzureSecurityKeyVaultKeysVersion>4.7.0</AzureSecurityKeyVaultKeysVersion> | ||
| </PropertyGroup> | ||
| <!-- Test Project Dependencies --> | ||
| <PropertyGroup> | ||
| <BenchmarkDotNetVersion>0.13.2</BenchmarkDotNetVersion> | ||
| <MicrosoftDotNetPlatformAbstractionsVersion>3.1.6</MicrosoftDotNetPlatformAbstractionsVersion> | ||
| <MicrosoftDotNetRemoteExecutorVersion>10.0.0-beta.25164.6</MicrosoftDotNetRemoteExecutorVersion> | ||
| <MicrosoftDotNetXUnitExtensionsVersion>10.0.0-beta.25164.6</MicrosoftDotNetXUnitExtensionsVersion> | ||
| <MicrosoftExtensionsHosting>8.0.1</MicrosoftExtensionsHosting> | ||
| <MicrosoftNETFrameworkReferenceAssembliesVersion>1.0.3</MicrosoftNETFrameworkReferenceAssembliesVersion> | ||
| <MicrosoftNETTestSdkVersion>17.11.1</MicrosoftNETTestSdkVersion> | ||
| <MicrosoftNETTestSdkVersion>17.12.0</MicrosoftNETTestSdkVersion> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👀 note to self to double check that tests still run
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please do - I eyeballed a bunch of the jobs, and tests are running. I didn't do an exhaustive comparison with a previous run. |
||
| <MicrosoftSqlServerSqlManagementObjectsVersion>172.52.0</MicrosoftSqlServerSqlManagementObjectsVersion> | ||
| <MicrosoftSqlServerTypesVersion>10.50.1600.1</MicrosoftSqlServerTypesVersion> | ||
| <MicrosoftSqlServerTypesVersionNet>160.1000.6</MicrosoftSqlServerTypesVersionNet> | ||
| <MicrosoftWin32RegistryVersion>5.0.0</MicrosoftWin32RegistryVersion> | ||
| <NewtonsoftJsonVersion>13.0.3</NewtonsoftJsonVersion> | ||
| <NewtonsoftJsonVersion>13.0.4</NewtonsoftJsonVersion> | ||
| <SystemDataOdbcVersion>8.0.1</SystemDataOdbcVersion> | ||
| <SystemFormatsAsn1Version>6.0.1</SystemFormatsAsn1Version> | ||
| <SystemRuntimeInteropServicesRuntimeInformationVersion>4.3.0</SystemRuntimeInteropServicesRuntimeInformationVersion> | ||
| <SystemSecurityCryptographyCngVersion>5.0.0</SystemSecurityCryptographyCngVersion> | ||
| <SystemSecurityPrincipalWindowsVersion>5.0.0</SystemSecurityPrincipalWindowsVersion> | ||
| <SystemServiceProcessServiceControllerVersion>8.0.1</SystemServiceProcessServiceControllerVersion> | ||
| <SystemTextEncodingCodePagesVersion>6.0.0</SystemTextEncodingCodePagesVersion> | ||
| <XunitVersion>2.9.2</XunitVersion> | ||
| <XunitVersion>2.9.3</XunitVersion> | ||
| <XunitrunnervisualstudioVersion>2.8.2</XunitrunnervisualstudioVersion> | ||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is supposed to provide the
System.Security.Cryptography.X509Certificates.X509CertificateLoadertype, which became required in .NET 9. But because we ended up only making the change conditionally for .NET 9, Framework code was unchanged and didn't need this type: https://github.com/dotnet/SqlClient/blob/main/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/VirtualSecureModeEnclaveProvider.cs#L172There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, saw the
#if NET_9_0_Or_Greaterconditionals and was able to remove this package without incident.