-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vcxproj global package restore #155
base: main
Are you sure you want to change the base?
Fix vcxproj global package restore #155
Conversation
…701.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21351.2
…705.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21355.2
…707.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21357.3
…709.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21359.3
…713.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21363.2
…714.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21364.3
…715.11 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21365.11
…716.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21366.1
…719.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21369.3
…720.12 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21370.12
…723.11 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21373.11
…726.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21376.4
…727.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21377.2
…728.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21378.2
…729.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21379.2
…803.5 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21403.5
…806.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21406.6
…810.8 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21410.8
…812.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21412.1
…813.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21413.4
…817.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21417.1
…818.12 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21418.12
…819.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21419.2
…820.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21420.4
…824.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21424.3
…825.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21425.3
…826.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21426.2
…827.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21427.6
…830.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21430.1
…901.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21451.3
…715.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22365.4
…717.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22367.1
…718.5 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22368.5
…719.9 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22369.9
…720.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22370.1
…721.8 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22371.8
…722.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22372.1
…725.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22375.4
…726.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22376.3
…727.15 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22377.15
…728.16 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22378.16
…729.10 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22379.10
…801.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22401.3
…802.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22402.4
…803.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22403.1
…805.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22405.2
…805.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22405.6
…808.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22408.3
…810.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22410.3
…811.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22314.8 -> To Version 7.0.0-beta.22411.2
…e-ba8c-29c8ad25514e [main] Update dependencies from dotnet/arcade
Remove custom SBOM fix
…s and there may or may not be a RID
@@ -157,4 +157,7 @@ | |||
<data name="WithTargets_assets" type="System.Resources.ResXFileRef, System.Windows.Forms"> | |||
<value>WithTargets.assets.json;System.Byte[], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value> | |||
</data> | |||
<data name="GlobalMSBuildPlugin_vcxproj" type="System.Resources.ResXFileRef, System.Windows.Forms"> | |||
<value>GlobalMSBuildPlugin.vcxproj.json;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-8</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: spaces vs tabs
@@ -779,7 +779,8 @@ private void GiveErrorForMissingFramework() | |||
nameof(Strings.MissingFrameworkInProjectJson) : | |||
nameof(Strings.MissingFrameworkInProjectFile); | |||
|
|||
ThrowExceptionIfNotAllowingFallback(missingFrameworkErrorString, TargetMonikers.First().ItemSpec); | |||
string itemSpec = TargetMonikers.FirstOrDefault()?.ItemSpec ?? "???"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would resolve the message as:
Your project does not reference "???" framework. Add a reference to "???" in the "TargetFrameworks" property of your project file and then re-run NuGet restore.
Which isn't super clear what it's talking about. I suppose it's better than an exception, but still doesn't seem very actionable (I at least wouldn't know what to do).
d33a600
to
caf84b8
Compare
Fix the case of .vcxproj file restore when there are no TargetMonikers and there may or may not be a RID. For #154