Don't hold onto references in Consumer#2191
Merged
AndreyAkinshin merged 3 commits intodotnet:masterfrom Feb 13, 2023
Merged
Conversation
Don't box nullable value types.
…KeepAliveWithoutBoxing.
timcassell
force-pushed
the
consumer-fix
branch
from
9cb5b48 to
bdb4037
Compare
Collaborator
Author
|
@AndreyAkinshin Does this look okay? |
AndreyAkinshin
approved these changes
Feb 13, 2023
Member
AndreyAkinshin
left a comment
AndreyAkinshin
left a comment
There was a problem hiding this comment.
It seems that everything is OK (at least, I wasn't able to find any regressions).
Member
|
@timcassell thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1942
Also fixes boxing nullable value types.